summaryrefslogtreecommitdiff
path: root/.gitreview
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-01-13 17:28:31 +0100
committerPatrick Georgi <pgeorgi@google.com>2021-02-07 21:57:13 +0000
commit244391a075ed2913ce2898c4aa60b98ca1852e4c (patch)
treeb633a18bf2ca128254ac913e2686426764c93267 /.gitreview
parent6b17794ddae1b3edb9992f383753914871d6fc3c (diff)
downloadcoreboot-244391a075ed2913ce2898c4aa60b98ca1852e4c.tar.xz
nb/intel/x4x: Unroll programming RCOMP data group
The RCOMP data group is special and is programmed differently. Prepare to simplify the code by programming it outside of the loop. Subsequent commits will simplify the logic even further, then clean up cosmetics. The special DDR3 case in the loop overwrites the command group strength multiplier value. It doesn't need to be programmed for each RCOMP group. Add a comment to justify not programming this register while programming the settings for the RCOMP data group. Tested on Asus P5QL PRO (DDR2), still boots. Change-Id: I5c2484f48e3c07e8e787b1894932e342e8e8a75c Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/49398 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Diffstat (limited to '.gitreview')
0 files changed, 0 insertions, 0 deletions