summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Roth <martinroth@google.com>2016-01-25 16:39:32 -0700
committerMartin Roth <martinroth@google.com>2016-01-30 17:28:19 +0100
commit08ee1cfafc2464cbeccaf3ede553b4c4e9b66367 (patch)
tree724c36a1e0185d1f3a1a05e5be57ddc983fcbfce
parent819e67242fa632f465f002396dc7adaec9418ab3 (diff)
downloadcoreboot-08ee1cfafc2464cbeccaf3ede553b4c4e9b66367.tar.xz
kconfig_lint: Add warning if tristate type is used in coreboot
Although there's no reason we COULDN'T use tristate types, we haven't up to this point. If there's a good reason to use them in the future, this check can be removed. Change-Id: I5f1903341f522bc957e394bc0fd288ba1adab431 Signed-off-by: Martin Roth <martinroth@google.com> Reviewed-on: https://review.coreboot.org/13460 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
-rwxr-xr-xutil/lint/kconfig_lint4
1 files changed, 4 insertions, 0 deletions
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint
index 93843367ff..8bdca8d09b 100755
--- a/util/lint/kconfig_lint
+++ b/util/lint/kconfig_lint
@@ -949,6 +949,10 @@ sub handle_type {
my $expression;
( $type, $expression ) = handle_if_line( $type, $inside_config, $filename, $line_no );
+ if ( $type =~ /tristate/ ) {
+ show_warning("$filename:$line_no - tristate types are not used.");
+ }
+
if ($inside_config) {
if ( exists( $symbols{$inside_config}{type} ) ) {
if ( $symbols{$inside_config}{type} !~ /$type/ ) {