diff options
| author | Jonathan Neuschäfer <j.neuschaefer@gmx.net> | 2016-05-17 17:40:09 +0200 |
|---|---|---|
| committer | Duncan Laurie <dlaurie@google.com> | 2016-05-17 23:27:02 +0200 |
| commit | 0ba307f0fe94550d84499562fb8f238f770aae3f (patch) | |
| tree | bf74dfa2269d40cab80b94a1e22cc070b7e6bb67 | |
| parent | 2296479dfd886d4cf4c145f1d3ed1ec64dc20630 (diff) | |
| download | coreboot-0ba307f0fe94550d84499562fb8f238f770aae3f.tar.xz | |
acpigen: Fix ?: operator confusion
strlen(string) was on the "negative" side of the selection operator, the
side where string is NULL.
Change-Id: Ic421a5406ef788c504e30089daeba61a195457ae
Reported-by: Coverity Scan (CID 1355263)
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-on: https://review.coreboot.org/14867
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins)
Reviewed-by: Duncan Laurie <dlaurie@google.com>
| -rw-r--r-- | src/arch/x86/acpigen.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c index 74efbb0534..226fba153c 100644 --- a/src/arch/x86/acpigen.c +++ b/src/arch/x86/acpigen.c @@ -206,7 +206,7 @@ void acpigen_emit_stream(const char *data, int size) void acpigen_emit_string(const char *string) { - acpigen_emit_stream(string, string ? 0 : strlen(string)); + acpigen_emit_stream(string, string ? strlen(string) : 0); acpigen_emit_byte('\0'); /* NUL */ } |