summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPraveen hodagatta pranesh <praveenx.hodagatta.pranesh@intel.com>2019-01-10 18:23:58 +0800
committerPatrick Georgi <pgeorgi@google.com>2019-01-16 11:57:24 +0000
commit0dbce4042f46475147db8a5d8cd211e1593e7043 (patch)
tree2ddc7d0b42851a2d2b500484da08c52f26337494
parentd6e00546a4cdce308a6a5480887ac03d94c3b826 (diff)
downloadcoreboot-0dbce4042f46475147db8a5d8cd211e1593e7043.tar.xz
mb/intel/kblrvp: Fix unsigned val casting of smaller size
Signed-off-by: Praveen hodagatta pranesh <praveenx.hodagatta.pranesh@intel.com> Change-Id: I519ed4b5b403622d6bb01ad0bdd04e01dedff7d8 Reviewed-on: https://review.coreboot.org/c/30794 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
-rw-r--r--src/mainboard/intel/kblrvp/board_id.c9
-rw-r--r--src/mainboard/intel/kblrvp/board_id.h4
-rw-r--r--src/mainboard/intel/kblrvp/romstage.c4
3 files changed, 10 insertions, 7 deletions
diff --git a/src/mainboard/intel/kblrvp/board_id.c b/src/mainboard/intel/kblrvp/board_id.c
index d4c4f535cb..a978e0ff86 100644
--- a/src/mainboard/intel/kblrvp/board_id.c
+++ b/src/mainboard/intel/kblrvp/board_id.c
@@ -36,12 +36,13 @@ int get_ec_boardinfo(void)
}
/* Get spd index */
-int get_spd_index(void)
+int get_spd_index(u8 *spd_index)
{
int ec_info = get_ec_boardinfo();
- if (ec_info >= 0)
- return ((uint16_t)ec_info >> 5) & 0x7;
-
+ if (ec_info >= 0) {
+ *spd_index = ((uint16_t)ec_info >> 5) & 0x7;
+ return 0;
+ }
return -1;
}
diff --git a/src/mainboard/intel/kblrvp/board_id.h b/src/mainboard/intel/kblrvp/board_id.h
index 239b76b12b..16eab690c6 100644
--- a/src/mainboard/intel/kblrvp/board_id.h
+++ b/src/mainboard/intel/kblrvp/board_id.h
@@ -16,6 +16,8 @@
#ifndef _MAINBOARD_BOARD_ID_H_
#define _MAINBOARD_BOARD_ID_H_
+#include <stdint.h>
+
/* Mobile Board Id 0x00 - 0xFF */
#define BOARD_ID_SKL_A0_RVP3 0x04
#define BOARD_ID_SKL_RVP7 0x0B
@@ -36,7 +38,7 @@
int get_ec_boardinfo(void);
/* Return spd index */
-int get_spd_index(void);
+int get_spd_index(u8 *spd_index);
/* Board id[15:8] */
int get_board_id(void);
diff --git a/src/mainboard/intel/kblrvp/romstage.c b/src/mainboard/intel/kblrvp/romstage.c
index 69c10bb9a0..8e5ffcf955 100644
--- a/src/mainboard/intel/kblrvp/romstage.c
+++ b/src/mainboard/intel/kblrvp/romstage.c
@@ -31,8 +31,8 @@ void mainboard_memory_init_params(FSPM_UPD *mupd)
{
FSP_M_CONFIG *mem_cfg;
mem_cfg = &mupd->FspmConfig;
- u8 spd_index = get_spd_index();
- if ((int)spd_index < 0)
+ u8 spd_index;
+ if (get_spd_index(&spd_index) < 0)
return;
printk(BIOS_INFO, "SPD index %d\n", spd_index);