diff options
| author | Jacob Garber <jgarber1@ualberta.ca> | 2019-06-04 15:13:46 -0600 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-06-21 08:30:24 +0000 |
| commit | 176670e31a156358cd8f2ac6ee4a5eb0dd74f54f (patch) | |
| tree | ee0a3c179289e3d0fab3509fb3e98cce7b251cc7 | |
| parent | 31755adc5ac77e1396e04f88a8c020bebea32461 (diff) | |
| download | coreboot-176670e31a156358cd8f2ac6ee4a5eb0dd74f54f.tar.xz | |
drivers/amd/agesa: Assert that StdHeader is non-null
Coverity believes there is a path where StdHeader is possibly
null. This *should* be incorrect, since the header is actually
initialized through the module dispatch framework, though Coverity
can't see it due to the extensive type-punning. However, the control
flow is so dizzingly complicated that I'm not even completely sure,
so adding an extra assert to be careful won't hurt anyway.
Change-Id: If3d7c5d5c5bba846e7453b3dbc824e2208d749fb
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1379932
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33214
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
| -rw-r--r-- | src/drivers/amd/agesa/state_machine.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/drivers/amd/agesa/state_machine.c b/src/drivers/amd/agesa/state_machine.c index c8529c5e04..750d192325 100644 --- a/src/drivers/amd/agesa/state_machine.c +++ b/src/drivers/amd/agesa/state_machine.c @@ -272,7 +272,7 @@ int agesa_execute_state(struct sysinfo *cb, AGESA_STRUCT_NAME func) /* Must call the function buffer was allocated for.*/ AMD_CONFIG_PARAMS *StdHeader = aip.NewStructPtr; - ASSERT(StdHeader->Func == func); + ASSERT(StdHeader != NULL && StdHeader->Func == func); if (CONFIG(AGESA_EXTRA_TIMESTAMPS) && task.ts_entry_id) timestamp_add_now(task.ts_entry_id); |