diff options
| author | John Zhao <john.zhao@intel.com> | 2020-09-22 11:12:37 -0700 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2020-09-28 09:24:33 +0000 |
| commit | 19e22f554e048edaca3ac56a4cf6d8698026e045 (patch) | |
| tree | 0081d4405f790b95d9c57485d4b81f12f6784df6 | |
| parent | 920d2b77f274ab511d22bb4a0ff6aa9e5b37b4c8 (diff) | |
| download | coreboot-19e22f554e048edaca3ac56a4cf6d8698026e045.tar.xz | |
drivers/spi: Check return value for error handling
Coverity detects calling function spi_sdcard_do_command without checking
return value. Fix this issue by checking return value for error
handling.
Found-by: Coverity CID 1407737
TEST=None
Signed-off-by: John Zhao <john.zhao@intel.com>
Change-Id: Ie0d28806b5c0b4c6d509e583d115358864eeff80
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45620
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
| -rw-r--r-- | src/drivers/spi/spi_sdcard.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/drivers/spi/spi_sdcard.c b/src/drivers/spi/spi_sdcard.c index 4eb033e87e..a670111891 100644 --- a/src/drivers/spi/spi_sdcard.c +++ b/src/drivers/spi/spi_sdcard.c @@ -354,7 +354,9 @@ static int spi_sdcard_do_app_command(const struct spi_sdcard *card, uint32_t *out_register) { /* CMD55 */ - spi_sdcard_do_command(card, APP_CMD, 0, NULL); + if (spi_sdcard_do_command(card, APP_CMD, 0, NULL)) + return -1; + return spi_sdcard_do_command_help(card, 1, cmd, argument, out_register); } |