summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Spiegel <richard.spiegel@amd.corp-partner.google.com>2018-05-30 17:26:11 -0700
committerMartin Roth <martinroth@google.com>2018-06-03 16:00:55 +0000
commit22e6018b282c9422c9517632045301ce5fa652ec (patch)
tree8b88f673299bea059e47f45d743b27786f01e731
parent8bd5c5f42ec68b6b6f753eb795ac37980d30d6f0 (diff)
downloadcoreboot-22e6018b282c9422c9517632045301ce5fa652ec.tar.xz
mb/google/kahlee: Remove #include <soc/smi.h>
Because of struct sci_source table of events that have to generate SCI or SMI, <soc/smi.h> was included to kahlee/grunt gpio.c files. However, new code transfered most of SCI/SMI/interrupt programming (with exception of events not associated to a GPIO pin), and therefore smi.h is now included by gpio.h. It was also added to some other files where they are not needed. Only smihandler.c truly needs it. Remove the includes. BUG=b:78139413 TEST=build and boot grunt. Change-Id: I64cf0796103a5226ddace03d05d94160bf93aa69 Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com> Reviewed-on: https://review.coreboot.org/26721 Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/kahlee/mainboard.c1
-rw-r--r--src/mainboard/google/kahlee/variants/baseboard/gpio.c1
-rw-r--r--src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h1
-rw-r--r--src/mainboard/google/kahlee/variants/kahlee/gpio.c1
4 files changed, 0 insertions, 4 deletions
diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c
index e090401ddf..6f7882fa1b 100644
--- a/src/mainboard/google/kahlee/mainboard.c
+++ b/src/mainboard/google/kahlee/mainboard.c
@@ -26,7 +26,6 @@
#include <smbios.h>
#include <soc/nvs.h>
#include <soc/pci_devs.h>
-#include <soc/smi.h>
#include <soc/southbridge.h>
#include <variant/ec.h>
#include <variant/thermal.h>
diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
index c7bd6a5be9..4a7cfaef51 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
@@ -16,7 +16,6 @@
#include <compiler.h>
#include <baseboard/variants.h>
#include <soc/gpio.h>
-#include <soc/smi.h>
#include <soc/southbridge.h>
#include <stdlib.h>
#include <boardid.h>
diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h
index fc754b5533..23f9cb014c 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h
+++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h
@@ -18,7 +18,6 @@
#define __BASEBOARD_VARIANTS_H__
#include <stddef.h>
-#include <soc/smi.h>
#include <soc/southbridge.h>
const struct sci_source *get_gpe_table(size_t *num);
diff --git a/src/mainboard/google/kahlee/variants/kahlee/gpio.c b/src/mainboard/google/kahlee/variants/kahlee/gpio.c
index 30723508db..75354deffa 100644
--- a/src/mainboard/google/kahlee/variants/kahlee/gpio.c
+++ b/src/mainboard/google/kahlee/variants/kahlee/gpio.c
@@ -14,7 +14,6 @@
*/
#include <baseboard/variants.h>
-#include <soc/smi.h>
#include <soc/southbridge.h>
#include <stdlib.h>
#include <variant/gpio.h>