summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKarthikeyan Ramasubramanian <kramasub@chromium.org>2020-03-05 11:58:34 -0800
committerPatrick Georgi <pgeorgi@google.com>2020-03-09 21:28:23 +0000
commit2c208bddc97e4eb2d0c5e445672c69b097cbc0cf (patch)
tree4c769fbfd17e57ab00466eda9b362c8296796e52
parent8499f7fb1b961f2d3bf1329897d0c6ff97ab5038 (diff)
downloadcoreboot-2c208bddc97e4eb2d0c5e445672c69b097cbc0cf.tar.xz
mb/google/dedede: Configure EC <-> AP GPIOs
BUG=b:150869661 TEST=Build and boot the mainboard. Trigger apreset from EC console. Trigger reboot from AP console. Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com> Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39325 Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/dedede/variants/baseboard/gpio.c4
-rw-r--r--src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h3
-rw-r--r--src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h3
3 files changed, 8 insertions, 2 deletions
diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c
index 31537e04c3..ce5e20df71 100644
--- a/src/mainboard/google/dedede/variants/baseboard/gpio.c
+++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c
@@ -126,9 +126,9 @@ static const struct pad_config gpio_table[] = {
/* C13 : GPP_C13/UART1_TXD */
PAD_NC(GPP_C13, NONE),
/* C14 : EC_IN_RW_OD */
- PAD_NC(GPP_C14, NONE),
+ PAD_CFG_GPI(GPP_C14, NONE, DEEP),
/* C15 : EC_AP_MKBP_INT_L */
- PAD_NC(GPP_C15, NONE),
+ PAD_CFG_GPI_APIC(GPP_C15, NONE, PLTRST, LEVEL, INVERT),
/* C16 : AP_I2C_TRACKPAD_SDA_3V3 */
PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1),
/* C17 : AP_I2C_TRACKPAD_SCL_3V3 */
diff --git a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h
index 2f0024c37a..0f356f882f 100644
--- a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h
+++ b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h
@@ -79,4 +79,7 @@
#define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */
#define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */
+/* Enable EC SYNC IRQ, EC_SYNC_IRQ is defined in baseboard/gpio.h */
+#define EC_ENABLE_SYNC_IRQ
+
#endif /* __BASEBOARD_EC_H__ */
diff --git a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h
index 395143b666..de94e76f3d 100644
--- a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h
+++ b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h
@@ -18,6 +18,9 @@
/* EC wake is LAN_WAKE# which is a special DeepSX wake pin */
#define GPE_EC_WAKE GPE0_LAN_WAK
+/* EC sync irq is GPP_C15_IRQ */
+#define EC_SYNC_IRQ GPP_C15_IRQ
+
/* Memory configuration board straps */
#define GPIO_MEM_CONFIG_0 GPP_C0
#define GPIO_MEM_CONFIG_1 GPP_C3