summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJacob Garber <jgarber1@ualberta.ca>2019-04-05 18:01:44 -0600
committerPatrick Georgi <pgeorgi@google.com>2019-04-08 14:16:02 +0000
commit3d25430b841d9cc31ee2f20384635e0714a8e9a0 (patch)
tree4b4261e141a439ad89e2a842723a4582139abe13
parentb70c77691ba9a26989fc8922a2e1807f6f8bdd09 (diff)
downloadcoreboot-3d25430b841d9cc31ee2f20384635e0714a8e9a0.tar.xz
libpayload/drivers/timer: Use 64 bits to prevent overflow
Cast cpu_khz to a 64 bit integer to prevent possible integer overflow (the multiplication is currently done using 32 bit math). Similar to 61dac13 (libpayload: timer: cast cpu_khz to make sure 64bit math is used). Found-by: Coverity Scan, CID 1261177 Signed-off-by: Jacob Garber <jgarber1@ualberta.ca> Change-Id: Iadb0abb7c7cc078f31a6d88d971f5d1b8ac62a9e Reviewed-on: https://review.coreboot.org/c/coreboot/+/32223 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
-rw-r--r--payloads/libpayload/drivers/timer/img_pistachio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/payloads/libpayload/drivers/timer/img_pistachio.c b/payloads/libpayload/drivers/timer/img_pistachio.c
index 070998faa9..d11c3ff283 100644
--- a/payloads/libpayload/drivers/timer/img_pistachio.c
+++ b/payloads/libpayload/drivers/timer/img_pistachio.c
@@ -18,7 +18,7 @@
uint64_t timer_hz(void)
{
- return lib_sysinfo.cpu_khz * 1000;
+ return (uint64_t)lib_sysinfo.cpu_khz * 1000;
}
uint64_t timer_raw_value(void)