summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Georgi <pgeorgi@chromium.org>2016-12-13 15:55:26 +0100
committerPatrick Georgi <pgeorgi@google.com>2016-12-14 18:03:13 +0100
commit4134680d465b6d33e6f3e3519a137fffd26541e1 (patch)
tree58c3b562293b048a286e9425700d582180e262da
parent5250852b0f5b789f610ffe6e460e57e16c39e04c (diff)
downloadcoreboot-4134680d465b6d33e6f3e3519a137fffd26541e1.tar.xz
libpayload/drivers/video: Improve check in if condition
Coverity considers this a copy&paste error, and maybe it is. In any case, it makes sense to check the variable that (if the condition is true) is changed, and the values are the same before that test, so the change is harmless. Change-Id: I163c6a9f5baa05e715861dc19643b19a9c79c883 Signed-off-by: Patrick Georgi <pgeorgi@chromium.org> Found-by: Coverity Scan #1347376 Reviewed-on: https://review.coreboot.org/17837 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth <martinroth@google.com>
-rw-r--r--payloads/libpayload/drivers/video/graphics.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/payloads/libpayload/drivers/video/graphics.c b/payloads/libpayload/drivers/video/graphics.c
index 943f8edcae..f1d916a18f 100644
--- a/payloads/libpayload/drivers/video/graphics.c
+++ b/payloads/libpayload/drivers/video/graphics.c
@@ -322,7 +322,7 @@ static int draw_bitmap_v3(const struct vector *top_left,
for (d.y = 0; d.y < dim->height; d.y++, p.y += dir) {
s0.y = d.y * scale->y.d / scale->y.n;
s1.y = s0.y;
- if (s0.y + 1 < dim_org->height)
+ if (s1.y + 1 < dim_org->height)
s1.y++;
ty.d = scale->y.n;
ty.n = (d.y * scale->y.d) % scale->y.n;