summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorrobbie zhang <robbie.zhang@intel.com>2015-09-10 16:24:44 -0700
committerPatrick Georgi <pgeorgi@google.com>2015-09-17 14:21:13 +0000
commit47a0b8494b59cf292dcc3372a01ee597b6de3923 (patch)
tree9822b94fcf045ea79110a14c7130c8dae3f917a6
parentd6a42f9af8776d2b2b924d6da0c08ce992da922a (diff)
downloadcoreboot-47a0b8494b59cf292dcc3372a01ee597b6de3923.tar.xz
glados/kunimitsu: remove the implementation of mainboard_add_dimm_info
This is a follow-up patch to https://chromium-review.googlesource.com/#/c/286877, after fsp support is landed in v1.5. BUG=chrome-os-partner:42975 BRANCH=none TEST=execute "mosys memory spd print all" on glados and kunimitsu Change-Id: I949e287372b190affac36a0efde8a30402eecdc8 Signed-off-by: Patrick Georgi <pgeorgi@chromium.org> Original-Commit-Id: 71a2e1838ff8bbaa358c167dad905b63d23c43fa Original-Change-Id: I64103af4f8456a053a955845a067062122f47af3 Original-Signed-off-by: Robbie Zhang <robbie.zhang@intel.com> Original-Reviewed-on: https://chromium-review.googlesource.com/298967 Original-Reviewed-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-on: http://review.coreboot.org/11657 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi@google.com>
-rw-r--r--src/mainboard/google/glados/romstage.c16
-rw-r--r--src/mainboard/intel/kunimitsu/romstage.c16
2 files changed, 0 insertions, 32 deletions
diff --git a/src/mainboard/google/glados/romstage.c b/src/mainboard/google/glados/romstage.c
index 315ddb9de8..69e6e0d872 100644
--- a/src/mainboard/google/glados/romstage.c
+++ b/src/mainboard/google/glados/romstage.c
@@ -21,7 +21,6 @@
#include <cbfs.h>
#include <console/console.h>
-#include <memory_info.h>
#include <string.h>
#include <ec/google/chromeec/ec.h>
#include <soc/gpio.h>
@@ -77,18 +76,3 @@ void mainboard_memory_init_params(struct romstage_params *params,
memory_params->MemorySpdDataLen = SPD_LEN;
memory_params->DqPinsInterleaved = FALSE;
}
-
-void mainboard_add_dimm_info(struct romstage_params *params,
- struct memory_info *mem_info,
- int channel, int dimm, int index)
-{
- /* Set the manufacturer */
- memcpy(&mem_info->dimm[index].mod_id,
- &params->pei_data->spd_data[channel][dimm][SPD_MANU_OFF],
- sizeof(mem_info->dimm[index].mod_id));
-
- /* Set the module part number */
- memcpy(mem_info->dimm[index].module_part_number,
- &params->pei_data->spd_data[channel][dimm][SPD_PART_OFF],
- sizeof(mem_info->dimm[index].module_part_number));
-}
diff --git a/src/mainboard/intel/kunimitsu/romstage.c b/src/mainboard/intel/kunimitsu/romstage.c
index af16dced97..a0eeafc9a5 100644
--- a/src/mainboard/intel/kunimitsu/romstage.c
+++ b/src/mainboard/intel/kunimitsu/romstage.c
@@ -21,7 +21,6 @@
#include <cbfs.h>
#include <console/console.h>
-#include <memory_info.h>
#include <string.h>
#include <ec/google/chromeec/ec.h>
#include <soc/gpio.h>
@@ -77,18 +76,3 @@ void mainboard_memory_init_params(struct romstage_params *params,
memory_params->MemorySpdDataLen = SPD_LEN;
memory_params->DqPinsInterleaved = FALSE;
}
-
-void mainboard_add_dimm_info(struct romstage_params *params,
- struct memory_info *mem_info,
- int channel, int dimm, int index)
-{
- /* Set the manufacturer */
- memcpy(&mem_info->dimm[index].mod_id,
- &params->pei_data->spd_data[channel][dimm][SPD_MANU_OFF],
- sizeof(mem_info->dimm[index].mod_id));
-
- /* Set the module part number */
- memcpy(mem_info->dimm[index].module_part_number,
- &params->pei_data->spd_data[channel][dimm][SPD_PART_OFF],
- sizeof(mem_info->dimm[index].module_part_number));
-}