summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarshall Dawson <marshalldawson3rd@gmail.com>2020-07-01 17:04:03 -0600
committerMarshall Dawson <marshalldawson3rd@gmail.com>2020-07-06 03:32:54 +0000
commit4d38c7546c702a60cae024f8681744264174f808 (patch)
tree1ae138aefc4af5e2219bc3afab8e3409f72e18e3
parent6663ad99cf36f53f454defc8f7e87eb2e7495255 (diff)
downloadcoreboot-4d38c7546c702a60cae024f8681744264174f808.tar.xz
soc/amd/picasso: Use PSP Sx command only for S3
Skip sending MboxBiosCmdSxInfo for sleep states other than S3. The PSP only acts on S3 and ignores all others. As a result, the command register is not cleared upon return and coreboot reports a timeout. BUG=b:153622879 TEST=Use halt from command line, verify command skipped. Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com> Change-Id: Ic47b8507e29e4c53898e88fb46e532b71df87d07 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43038 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
-rw-r--r--src/soc/amd/picasso/smihandler.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/soc/amd/picasso/smihandler.c b/src/soc/amd/picasso/smihandler.c
index 992dc2b55a..7e762a9abb 100644
--- a/src/soc/amd/picasso/smihandler.c
+++ b/src/soc/amd/picasso/smihandler.c
@@ -208,7 +208,8 @@ static void sb_slp_typ_handler(void)
reg32);
} /* if (CONFIG(ELOG_GSMI)) */
- psp_notify_sx_info(slp_typ);
+ if (slp_typ == ACPI_S3)
+ psp_notify_sx_info(ACPI_S3);
smu_sx_entry(); /* Leave SlpTypeEn clear, SMU will set */
printk(BIOS_ERR, "Error: System did not go to sleep\n");