diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-01-06 16:13:07 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-01-07 10:38:26 +0000 |
| commit | 5bd926428eb0972074ec056835eb0f85984846d3 (patch) | |
| tree | 39ec9a805f2a92b2d178dfdd214900ca04458b05 | |
| parent | 954ed5500c2d8d2284b65689b720ca1530c28b25 (diff) | |
| download | coreboot-5bd926428eb0972074ec056835eb0f85984846d3.tar.xz | |
usbdebug: Sanity check PCI EHCI location
If requested EHCI function is not on bus 0, we would
need to open MMIO windows and configuration register
space for the connected upstream PCI bridge for it
to work. We don't plan to do so.
Change-Id: I7c1c60f9d9890dedfedc9d977faf5152ba362692
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/30692
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
| -rw-r--r-- | src/drivers/usb/pci_ehci.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/drivers/usb/pci_ehci.c b/src/drivers/usb/pci_ehci.c index e0f88ec098..c05129163e 100644 --- a/src/drivers/usb/pci_ehci.c +++ b/src/drivers/usb/pci_ehci.c @@ -34,6 +34,10 @@ int ehci_debug_hw_enable(unsigned int *base, unsigned int *dbg_offset) { pci_devfn_t dbg_dev = pci_ehci_dbg_dev(CONFIG_USBDEBUG_HCD_INDEX); + /* We only support controllers on bus 0. */ + if (PCI_DEV2SEGBUS(dbg_dev) != 0) + return -1; + #ifdef __SIMPLE_DEVICE__ pci_devfn_t dev = dbg_dev; #else |