diff options
| author | Gabe Black <gabeblack@google.com> | 2013-05-18 15:52:01 -0700 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2013-07-10 20:10:12 +0200 |
| commit | 63dd2cb62a780158571c4cf5465ce7953a0e38fc (patch) | |
| tree | 16ed99313e365315085e6464956cb6e8516667cf | |
| parent | ea9c98d454e4ea60452de1bbe38dfeea857c3142 (diff) | |
| download | coreboot-63dd2cb62a780158571c4cf5465ce7953a0e38fc.tar.xz | |
exynos5250: When enabling the I2S pins, turn off pull ups/downs.
These pins will be driven by the internal controller which shouldn't have pull
ups or downs in the pin fighting with them.
Change-Id: I579aed84ace45d8f5f1d3ca64c064d98de842b57
Signed-off-by: Gabe Black <gabeblack@chromium.org>
Reviewed-on: http://review.coreboot.org/3649
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
| -rw-r--r-- | src/cpu/samsung/exynos5250/pinmux.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/cpu/samsung/exynos5250/pinmux.c b/src/cpu/samsung/exynos5250/pinmux.c index 6991dfc5c7..9a473d0b2a 100644 --- a/src/cpu/samsung/exynos5250/pinmux.c +++ b/src/cpu/samsung/exynos5250/pinmux.c @@ -286,8 +286,10 @@ int exynos_pinmux_config(enum periph_id peripheral, int flags) gpio_set_pull(GPIO_X07, GPIO_PULL_NONE); break; case PERIPH_ID_I2S1: - for (i = 0; i < 5; i++) + for (i = 0; i < 5; i++) { gpio_cfg_pin(GPIO_B00 + i, GPIO_FUNC(0x02)); + gpio_set_pull(GPIO_B00 + i, GPIO_PULL_NONE); + } break; default: printk(BIOS_DEBUG, "%s: invalid peripheral %d", __func__, peripheral); |