diff options
| author | Arthur Heymans <arthur@aheymans.xyz> | 2019-10-08 10:04:51 +0200 |
|---|---|---|
| committer | Marshall Dawson <marshalldawson3rd@gmail.com> | 2020-10-30 13:50:00 +0000 |
| commit | 69c0b19ae1d17f52907d1d31ac45a48b6fe426a7 (patch) | |
| tree | 1884f8fa28160fd2c2a79de86e78bbbed04cd463 | |
| parent | fdcbae0a9bec7adb4f0db3d5479813be42b4f323 (diff) | |
| download | coreboot-69c0b19ae1d17f52907d1d31ac45a48b6fe426a7.tar.xz | |
{soc/amd,sb/amd/hudson}: Fix generating the ACPI mcfg
The last argument for acpi_fill_mcfg() is the last PCI bus, which is
an uint8_t, not the total number of busses, which overflows the
argument if CONFIG_MMCONF_BUS_NUMBER is 256.
Change-Id: I8887e14128dbe54688eb6e803d6694b7c29956c1
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35872
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-by: Michał Żygowski <michal.zygowski@3mdeb.com>
| -rw-r--r-- | src/soc/amd/stoneyridge/northbridge.c | 2 | ||||
| -rw-r--r-- | src/southbridge/amd/pi/hudson/lpc.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c index 63ab6b4e81..0f66927e45 100644 --- a/src/soc/amd/stoneyridge/northbridge.c +++ b/src/soc/amd/stoneyridge/northbridge.c @@ -170,7 +170,7 @@ unsigned long acpi_fill_mcfg(unsigned long current) CONFIG_MMCONF_BASE_ADDRESS, 0, 0, - CONFIG_MMCONF_BUS_NUMBER); + CONFIG_MMCONF_BUS_NUMBER - 1); return current; } diff --git a/src/southbridge/amd/pi/hudson/lpc.c b/src/southbridge/amd/pi/hudson/lpc.c index c884f209d3..b77548ecbb 100644 --- a/src/southbridge/amd/pi/hudson/lpc.c +++ b/src/southbridge/amd/pi/hudson/lpc.c @@ -324,7 +324,7 @@ unsigned long acpi_fill_mcfg(unsigned long current) CONFIG_MMCONF_BASE_ADDRESS, 0, 0, - CONFIG_MMCONF_BUS_NUMBER); + CONFIG_MMCONF_BUS_NUMBER - 1); return current; } |