diff options
| author | Patrick Georgi <pgeorgi@google.com> | 2020-06-29 22:28:18 +0200 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2020-06-30 22:27:21 +0000 |
| commit | 6f5e5e5aa8912ec746ac52b649ddaeae75c25318 (patch) | |
| tree | c835b21f58cf9d3ab959b7050512332c10ee8960 | |
| parent | a5c2b48e13ad2df799aade19e3e4e601f9477063 (diff) | |
| download | coreboot-6f5e5e5aa8912ec746ac52b649ddaeae75c25318.tar.xz | |
src/arch/x86: Ensure $(objgenerated) exists before it's used
In some rare cases it seems that make tries to build
$(objgenerated)/assembly.inc before the build-dirs target has finished,
and so assembly.inc can't be written. Enforce that build-dirs is done
before assembly.inc starts.
BUG=chromium:1098215
BRANCH=none
TEST=none
Change-Id: Ib141ea45a43836cfdde0059523c331fe5286b06d
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42883
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
| -rw-r--r-- | src/arch/x86/Makefile.inc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 6297384b2f..1a1aa408b1 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -50,7 +50,7 @@ pci$(stripped_vgabios_dgpu_id).rom-type := optionrom # into a single generated file. crt0s = $(cpu_incs-y) -$(objgenerated)/assembly.inc: $$(crt0s) +$(objgenerated)/assembly.inc: build-dirs $$(crt0s) @printf " GEN $(subst $(obj)/,,$(@))\n" printf '$(foreach crt0,$(crt0s),#include "$(crt0)"\n)' > $@ |