diff options
| author | Michael Niewöhner <foss@mniewoehner.de> | 2020-11-02 22:44:44 +0100 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2020-11-20 00:10:59 +0000 |
| commit | 71b3edd779638554281512ce2ef733876c1feaf7 (patch) | |
| tree | 60e1567a89a2c86a18b00d271719dcb1aeb86c98 | |
| parent | 275adeaf0ba4ce2255d6b767e55adf56ea358a50 (diff) | |
| download | coreboot-71b3edd779638554281512ce2ef733876c1feaf7.tar.xz | |
soc/intel/common/acpi: correct return value for PEPD enum function
The PEPD enum function returns a bitmask to announce supported/enabled
PEPD functions. Add a comment describing this bitmask and correct the
return value to announce function 1, 5 and 6 as supported.
Also add comments to the disabled functions 3 and 4.
Change-Id: Ib523a54f5ad695e79005aba422282e03f2bc4bed
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47140
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
| -rw-r--r-- | src/soc/intel/common/block/acpi/acpi/pep.asl | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/src/soc/intel/common/block/acpi/acpi/pep.asl b/src/soc/intel/common/block/acpi/acpi/pep.asl index 9e39a8fedd..ef6707647f 100644 --- a/src/soc/intel/common/block/acpi/acpi/pep.asl +++ b/src/soc/intel/common/block/acpi/acpi/pep.asl @@ -26,7 +26,12 @@ Device(PEPD) * Enum functions */ If(Arg2 == PEPD_DSM_LPI_ENUM_FUNCTIONS) { - Return(Buffer(One) {0x60}) + /* + * Supported functions bitmask + * bit 0: other functions than 0 are supported + * bits 1-6: function x supported + */ + Return(Buffer(1) {0x63}) } /* * Function 1 - Get Device Constraints @@ -56,16 +61,19 @@ Device(PEPD) * Function 2 - Get Crash Dump Device */ If(Arg2 == PEPD_DSM_LPI_GET_CRASH_DUMP_DEV) { + /* not yet used and not advertised by function 0 */ } /* * Function 3 - Display Off Notification */ If(Arg2 == PEPD_DSM_LPI_DISPLAY_OFF_NOTIFY) { + /* not yet used and not advertised by function 0 */ } /* * Function 4 - Display On Notification */ If(Arg2 == PEPD_DSM_LPI_DISPLAY_ON_NOTIFY) { + /* not yet used and not advertised by function 0 */ } /* * Function 5 - Low Power S0 Entry Notification |