summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZheng Bao <fishbaozi@gmail.com>2021-01-23 10:09:00 +0800
committerFelix Held <felix-coreboot@felixheld.de>2021-01-27 15:40:50 +0000
commit8516c219cef48dc6de650a898870760113f5b324 (patch)
tree37d105285038bf01281e520a37d0df4a798f8348
parent3765b50374f223488a776dfa5c5c9aad0d39d9f0 (diff)
downloadcoreboot-8516c219cef48dc6de650a898870760113f5b324.tar.xz
soc/amd: Throw an error if FWM_POSITION_INDEX is empty
The empty string causes an undetectable build error. Filter out the board which doesn't define this variable. A great odds that the reason is the board doesn't set a valid ROM size. Change-Id: Iade1961460285acdec245c553c7b84014c30c267 Signed-off-by: Zheng Bao <fishbaozi@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/49855 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
-rw-r--r--src/soc/amd/cezanne/Makefile.inc3
-rw-r--r--src/soc/amd/picasso/Makefile.inc3
2 files changed, 6 insertions, 0 deletions
diff --git a/src/soc/amd/cezanne/Makefile.inc b/src/soc/amd/cezanne/Makefile.inc
index 46ac199649..ef099de593 100644
--- a/src/soc/amd/cezanne/Makefile.inc
+++ b/src/soc/amd/cezanne/Makefile.inc
@@ -45,6 +45,9 @@ MAINBOARD_BLOBS_DIR:=$(top)/3rdparty/blobs/mainboard/$(MAINBOARDDIR)
# | | PSPDIR ADDR | BIOSDIR ADDR |
# +-----------+---------------+----------------+
+$(if $(CONFIG_AMD_FWM_POSITION_INDEX), ,\
+ $(error Invalid AMD firmware position index. Check if the board sets a valid ROM size))
+
CEZANNE_FWM_POSITION=$(call int-add, \
$(call int-subtract, 0xffffffff \
$(call int-shift-left, \
diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.inc
index 5dac1f6950..5152d4713a 100644
--- a/src/soc/amd/picasso/Makefile.inc
+++ b/src/soc/amd/picasso/Makefile.inc
@@ -84,6 +84,9 @@ MAINBOARD_BLOBS_DIR:=$(top)/3rdparty/blobs/mainboard/$(MAINBOARDDIR)
# | | PSPDIR ADDR | BIOSDIR ADDR |
# +-----------+---------------+----------------+
+$(if $(CONFIG_AMD_FWM_POSITION_INDEX), ,\
+ $(error Invalid AMD firmware position index. Check if the board sets a valid ROM size))
+
PICASSO_FWM_POSITION=$(call int-add, \
$(call int-subtract, 0xffffffff \
$(call int-shift-left, \