summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRaul E Rangel <rrangel@chromium.org>2021-01-22 10:04:59 -0700
committerFelix Held <felix-coreboot@felixheld.de>2021-01-28 00:24:33 +0000
commit892a423de8520fda2735835faed7870c3bbf420f (patch)
tree5ef5d335f01d240b6de7cede524e4a77df327b7e
parent613f9fc91f7b3894d862dc48e118d212f788381b (diff)
downloadcoreboot-892a423de8520fda2735835faed7870c3bbf420f.tar.xz
soc/amd/picasso/acpi: Remove DMA addresses for UARTs
This is not the correct way to specify the FixedDMA devices. I'm removing for now since it adds confusion. BUG=none BRANCH=zork TEST=Boot zork to linux and make sure UART still works Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: I17b9c8dbe4f9c4b64ee1bd69cb9b30998e727632 Reviewed-on: https://review.coreboot.org/c/coreboot/+/49843 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
-rw-r--r--src/soc/amd/picasso/acpi/sb_fch.asl8
1 files changed, 0 insertions, 8 deletions
diff --git a/src/soc/amd/picasso/acpi/sb_fch.asl b/src/soc/amd/picasso/acpi/sb_fch.asl
index 32268da998..6c3c51dedf 100644
--- a/src/soc/amd/picasso/acpi/sb_fch.asl
+++ b/src/soc/amd/picasso/acpi/sb_fch.asl
@@ -106,7 +106,6 @@ Device (FUR0)
Exclusive, , , IRQR)
{ 0 }
Memory32Fixed (ReadWrite, APU_UART0_BASE, 0x1000)
- Memory32Fixed (ReadWrite, APU_DMAC0_BASE, 0x1000)
}
CreateDWordField (Local0, IRQR._INT, IRQN)
If (PICM) {
@@ -117,7 +116,6 @@ Device (FUR0)
If (IRQN == 0x1f) {
Return (ResourceTemplate() {
Memory32Fixed (ReadWrite, APU_UART0_BASE, 0x1000)
- Memory32Fixed (ReadWrite, APU_DMAC0_BASE, 0x1000)
})
} Else {
Return (Local0)
@@ -139,7 +137,6 @@ Device (FUR1) {
Exclusive, , , IRQR)
{ 0 }
Memory32Fixed (ReadWrite, APU_UART1_BASE, 0x1000)
- Memory32Fixed (ReadWrite, APU_DMAC1_BASE, 0x1000)
}
CreateDWordField (Local0, IRQR._INT, IRQN)
If (PICM) {
@@ -150,7 +147,6 @@ Device (FUR1) {
If (IRQN == 0x1f) {
Return (ResourceTemplate() {
Memory32Fixed (ReadWrite, APU_UART1_BASE, 0x1000)
- Memory32Fixed (ReadWrite, APU_DMAC1_BASE, 0x1000)
})
} Else {
Return (Local0)
@@ -172,7 +168,6 @@ Device (FUR2) {
Exclusive, , , IRQR)
{ 0 }
Memory32Fixed (ReadWrite, APU_UART2_BASE, 0x1000)
- Memory32Fixed (ReadWrite, APU_DMAC2_BASE, 0x1000)
}
CreateDWordField (Local0, IRQR._INT, IRQN)
If (PICM) {
@@ -183,7 +178,6 @@ Device (FUR2) {
If (IRQN == 0x1f) {
Return (ResourceTemplate() {
Memory32Fixed (ReadWrite, APU_UART2_BASE, 0x1000)
- Memory32Fixed (ReadWrite, APU_DMAC2_BASE, 0x1000)
})
} Else {
Return (Local0)
@@ -205,7 +199,6 @@ Device (FUR3) {
Exclusive, , , IRQR)
{ 0 }
Memory32Fixed (ReadWrite, APU_UART3_BASE, 0x1000)
- Memory32Fixed (ReadWrite, APU_DMAC3_BASE, 0x1000)
}
CreateDWordField (Local0, IRQR._INT, IRQN)
If (PICM) {
@@ -216,7 +209,6 @@ Device (FUR3) {
If (IRQN == 0x1f) {
Return (ResourceTemplate() {
Memory32Fixed (ReadWrite, APU_UART3_BASE, 0x1000)
- Memory32Fixed (ReadWrite, APU_DMAC3_BASE, 0x1000)
})
} Else {
Return (Local0)