summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Banon <mikebdp2@gmail.com>2020-08-15 10:30:19 +0300
committerPatrick Georgi <pgeorgi@google.com>2020-08-24 09:18:12 +0000
commit8b7bda40f140e3d849a91660d2c84a4c324c8901 (patch)
tree7349796f92e0f5864397fc74a79210b8d889e56d
parentd2a00d7a1c7c93b9f149e1c2c8150c1114d1374d (diff)
downloadcoreboot-8b7bda40f140e3d849a91660d2c84a4c324c8901.tar.xz
nb/amd/agesa: define DDR3_SPD_SIZE as a common value
Move a size of DDR3 SPD memory (always 256 bytes) to a common define. Signed-off-by: Mike Banon <mikebdp2@gmail.com> Change-Id: I80c89ff6e44526e1d75b0e933b21801ed17c98c0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44498 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rw-r--r--src/northbridge/amd/agesa/family14/dimmSpd.c2
-rw-r--r--src/northbridge/amd/agesa/family15tn/dimmSpd.c2
-rw-r--r--src/northbridge/amd/agesa/family16kb/dimmSpd.c2
-rw-r--r--src/vendorcode/amd/agesa/f14/AGESA.h3
-rw-r--r--src/vendorcode/amd/agesa/f15tn/AGESA.h3
-rw-r--r--src/vendorcode/amd/agesa/f16kb/AGESA.h3
6 files changed, 9 insertions, 6 deletions
diff --git a/src/northbridge/amd/agesa/family14/dimmSpd.c b/src/northbridge/amd/agesa/family14/dimmSpd.c
index e4d1eab2d8..3ce84a46f6 100644
--- a/src/northbridge/amd/agesa/family14/dimmSpd.c
+++ b/src/northbridge/amd/agesa/family14/dimmSpd.c
@@ -40,7 +40,7 @@ AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINTN unused2, AGESA_READ_SPD_PAR
if (spdAddress == 0)
return AGESA_ERROR;
- int err = smbus_readSpd(spdAddress, (void *) info->Buffer, 256);
+ int err = smbus_readSpd(spdAddress, (void *) info->Buffer, DDR3_SPD_SIZE);
if (err)
return AGESA_ERROR;
return AGESA_SUCCESS;
diff --git a/src/northbridge/amd/agesa/family15tn/dimmSpd.c b/src/northbridge/amd/agesa/family15tn/dimmSpd.c
index 6504d1475d..70a7b92be0 100644
--- a/src/northbridge/amd/agesa/family15tn/dimmSpd.c
+++ b/src/northbridge/amd/agesa/family15tn/dimmSpd.c
@@ -39,7 +39,7 @@ AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINTN unused2, AGESA_READ_SPD_PAR
if (spdAddress == 0)
return AGESA_ERROR;
- int err = hudson_readSpd(spdAddress, (void *) info->Buffer, 256);
+ int err = hudson_readSpd(spdAddress, (void *) info->Buffer, DDR3_SPD_SIZE);
if (err)
return AGESA_ERROR;
return AGESA_SUCCESS;
diff --git a/src/northbridge/amd/agesa/family16kb/dimmSpd.c b/src/northbridge/amd/agesa/family16kb/dimmSpd.c
index b20216f993..58b35e09fd 100644
--- a/src/northbridge/amd/agesa/family16kb/dimmSpd.c
+++ b/src/northbridge/amd/agesa/family16kb/dimmSpd.c
@@ -39,7 +39,7 @@ AGESA_STATUS AmdMemoryReadSPD (UINT32 unused1, UINTN unused2, AGESA_READ_SPD_PAR
if (spdAddress == 0)
return AGESA_ERROR;
- int err = hudson_readSpd(spdAddress, (void *) info->Buffer, 256);
+ int err = hudson_readSpd(spdAddress, (void *) info->Buffer, DDR3_SPD_SIZE);
if (err)
return AGESA_ERROR;
return AGESA_SUCCESS;
diff --git a/src/vendorcode/amd/agesa/f14/AGESA.h b/src/vendorcode/amd/agesa/f14/AGESA.h
index 03f1670049..e7d02fa9c5 100644
--- a/src/vendorcode/amd/agesa/f14/AGESA.h
+++ b/src/vendorcode/amd/agesa/f14/AGESA.h
@@ -1158,9 +1158,10 @@ typedef enum {
///
/// SPD Data for each DIMM.
///
+#define DDR3_SPD_SIZE 256
typedef struct _SPD_DEF_STRUCT {
IN BOOLEAN DimmPresent; ///< Indicates that the DIMM is present and Data is valid
- IN UINT8 Data[256]; ///< Buffer for 256 Bytes of SPD data from DIMM
+ IN UINT8 Data[DDR3_SPD_SIZE]; ///< Buffer for 256 Bytes of SPD data from DIMM
} SPD_DEF_STRUCT;
///
diff --git a/src/vendorcode/amd/agesa/f15tn/AGESA.h b/src/vendorcode/amd/agesa/f15tn/AGESA.h
index 922a8ee633..d41a5eec77 100644
--- a/src/vendorcode/amd/agesa/f15tn/AGESA.h
+++ b/src/vendorcode/amd/agesa/f15tn/AGESA.h
@@ -1546,9 +1546,10 @@ typedef enum {
///
/// SPD Data for each DIMM.
///
+#define DDR3_SPD_SIZE 256
typedef struct _SPD_DEF_STRUCT {
IN BOOLEAN DimmPresent; ///< Indicates that the DIMM is present and Data is valid
- IN UINT8 Data[256]; ///< Buffer for 256 Bytes of SPD data from DIMM
+ IN UINT8 Data[DDR3_SPD_SIZE]; ///< Buffer for 256 Bytes of SPD data from DIMM
} SPD_DEF_STRUCT;
///
diff --git a/src/vendorcode/amd/agesa/f16kb/AGESA.h b/src/vendorcode/amd/agesa/f16kb/AGESA.h
index 7e43de416c..853fdc99e6 100644
--- a/src/vendorcode/amd/agesa/f16kb/AGESA.h
+++ b/src/vendorcode/amd/agesa/f16kb/AGESA.h
@@ -1621,9 +1621,10 @@ typedef enum {
///
/// SPD Data for each DIMM.
///
+#define DDR3_SPD_SIZE 256
typedef struct _SPD_DEF_STRUCT {
IN BOOLEAN DimmPresent; ///< Indicates that the DIMM is present and Data is valid
- IN UINT8 Data[256]; ///< Buffer for 256 Bytes of SPD data from DIMM
+ IN UINT8 Data[DDR3_SPD_SIZE]; ///< Buffer for 256 Bytes of SPD data from DIMM
} SPD_DEF_STRUCT;
///