diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-12-26 10:57:51 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2020-01-02 12:37:08 +0000 |
| commit | a04dee6895ec12927712f0f43009e534662b5088 (patch) | |
| tree | 66759e36b59917eff7299f5b451dbab3ac5c120b | |
| parent | bee82ab798c542051bda684fed3921be5923c84e (diff) | |
| download | coreboot-a04dee6895ec12927712f0f43009e534662b5088.tar.xz | |
drivers/pc80/mc146818rtc: Remove read_option_lowlevel()
This was a workaround for romcc.
Change-Id: I34f41390afbd88f3ace7003fd18c2edd56712a67
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37954
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/drivers/pc80/rtc/mc146818rtc.c | 12 | ||||
| -rw-r--r-- | src/include/pc80/mc146818rtc.h | 5 |
2 files changed, 0 insertions, 17 deletions
diff --git a/src/drivers/pc80/rtc/mc146818rtc.c b/src/drivers/pc80/rtc/mc146818rtc.c index d3efdec16d..2029b1e51f 100644 --- a/src/drivers/pc80/rtc/mc146818rtc.c +++ b/src/drivers/pc80/rtc/mc146818rtc.c @@ -345,18 +345,6 @@ static enum cb_err set_cmos_value(unsigned long bit, unsigned long length, return CB_SUCCESS; } -unsigned int read_option_lowlevel(unsigned int start, unsigned int size, - unsigned int def) -{ - printk(BIOS_NOTICE, "NOTICE: read_option() used to access CMOS " - "from non-ROMCC code, please use get_option() instead.\n"); - if (CONFIG(USE_OPTION_TABLE)) { - const unsigned char byte = cmos_read(start / 8); - return (byte >> (start & 7U)) & ((1U << size) - 1U); - } - return def; -} - enum cb_err set_option(const char *name, void *value) { struct cmos_option_table *ct; diff --git a/src/include/pc80/mc146818rtc.h b/src/include/pc80/mc146818rtc.h index ecfa76dfbb..aa50773750 100644 --- a/src/include/pc80/mc146818rtc.h +++ b/src/include/pc80/mc146818rtc.h @@ -185,14 +185,9 @@ int cmos_chksum_valid(void); enum cb_err set_option(const char *name, void *val); enum cb_err get_option(void *dest, const char *name); -unsigned int read_option_lowlevel(unsigned int start, unsigned int size, - unsigned int def); int do_normal_boot(void); -#define read_option(name, default) read_option_lowlevel(CMOS_VSTART_ ##name, \ - CMOS_VLEN_ ##name, (default)) - #if CONFIG(CMOS_POST) #if CONFIG(USE_OPTION_TABLE) # include "option_table.h" |