summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorzbao <fishbaozi@gmail.com>2012-04-19 12:42:51 +0800
committerPatrick Georgi <patrick@georgi-clan.de>2012-04-19 08:46:14 +0200
commita20132b0b26fca4c07de491143fa655859431696 (patch)
tree9d28d2e50fffe63b7c82a2cbc0f62d045e27b6ab
parent2132005b2041b24136c09220b73a7cef698b22b2 (diff)
downloadcoreboot-a20132b0b26fca4c07de491143fa655859431696.tar.xz
Do not produce temp s3.rom if the board doesn't need it.
S3.rom is useless for all the other boards which don't use flash to save sleep/wakeup settings. AGESA-based boards other than persimmon haven't been validated the S3 resume. They don't need S3.rom yet. Change-Id: I12693e9556ca6f8e0d80b2ab2dca5c85bdb97685 Signed-off-by: Zheng Bao <zheng.bao@amd.com> Signed-off-by: zbao <fishbaozi@gmail.com> Reviewed-on: http://review.coreboot.org/902 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
-rw-r--r--src/southbridge/amd/Makefile.inc8
1 files changed, 6 insertions, 2 deletions
diff --git a/src/southbridge/amd/Makefile.inc b/src/southbridge/amd/Makefile.inc
index f4a9cbb69d..d7b5645ea8 100644
--- a/src/southbridge/amd/Makefile.inc
+++ b/src/southbridge/amd/Makefile.inc
@@ -15,14 +15,18 @@ subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB700) += cimx
subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB800) += cimx
subdirs-$(CONFIG_SOUTHBRIDGE_AMD_CIMX_SB900) += cimx
+ifeq ($(CONFIG_HAVE_ACPI_RESUME), y)
+ifeq ($(CONFIG_CPU_AMD_AGESA), y)
+
$(obj)/s3.rom:
echo " S3 NVRAM 0xffff0000 (S3 storage area)"
awk 'BEGIN {for (i=0; i<20480; i++) {printf "%c", 255}}' > $@.tmp
mv $@.tmp $@
-ifeq ($(CONFIG_HAVE_ACPI_RESUME), y)
cbfs-files-y += s3nv
s3nv-file := $(obj)/s3.rom
s3nv-position := 0xffff0000
s3nv-type := raw
-endif
+
+endif # CONFIG_CPU_AMD_AGESA == y
+endif # CONFIG_HAVE_ACPI_RESUME == y