summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorzbao <fishbaozi@gmail.com>2012-07-24 17:58:30 +0800
committerRonald G. Minnich <rminnich@gmail.com>2012-07-25 22:21:24 +0200
commita36d8b38a673f8792df0e36c94ef571b08b229b5 (patch)
tree7155f01ed263fe78c9a483c0b9fa0aba4a6f9af6
parent19a185448a40461d0df53e907a80ed1814695e5e (diff)
downloadcoreboot-a36d8b38a673f8792df0e36c94ef571b08b229b5.tar.xz
AMD Family 15tn: Set the default return value as AGESA_SUCCESS instead of TRUE
The default return value should be AGESA_SUCCESS, which is zero. If it was set as TRUE, the AGESA wrapper would think it was AGESA_UNSUPPORTED. That would make no sense. And it would produce ASSERT warning in AGESA wrapper. On my parmer board, with Engine sample processor, it can not create the correct DMI table. Routine initlate will return AGESS_ERROR. ------Serial message--------- ASSERTION FAILED: file 'src/mainboard/amd/parmer/agesawrapper.c', line 427 DmiTable:100123c3, AcpiPstatein: 10010126, AcpiSrat:0,AcpiSlit:0, Mce:100111ba, Cmc:1001127c,Alib:1001ccd4, AcpiIvrs:0 in agesawrapper_amdinitlate agesawrapper_amdinitlate failed: 5 ----------------------------- I believe the processor with acceptable name string will create the right DMI. Change-Id: Ie86955cf9affffc964a7c9f4a2c63077ef2030de Signed-off-by: Zheng Bao <zheng.bao@amd.com> Signed-off-by: zbao <fishbaozi@gmail.com> Reviewed-on: http://review.coreboot.org/1350 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
-rw-r--r--src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c b/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c
index 23fd79f1f9..2e7d905f2c 100644
--- a/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c
+++ b/src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuDmi.c
@@ -245,7 +245,7 @@ GetDmiInfoMain (
CPU_GET_MEM_INFO CpuGetMemInfo;
MsrData = 0;
- Flag = TRUE;
+ Flag = AGESA_SUCCESS;
ProcData = NULL;
MemInfo = NULL;
DmiBufferPtr = *DmiTable;
@@ -473,7 +473,7 @@ GetType4Type7Info (
PROC_FAMILY_TABLE *ProcData;
CPU_LOGICAL_ID LogicalID;
- Flag = TRUE;
+ Flag = AGESA_SUCCESS;
DmiBufferPtr = (DMI_INFO *) ApExeParams->RelatedDataBlock;
GetLogicalIdOfCurrentCore (&LogicalID, &ApExeParams->StdHeader);