summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Wang <chris.wang@amd.corp-partner.google.com>2020-12-01 17:14:17 +0800
committerPatrick Georgi <pgeorgi@google.com>2020-12-05 08:20:58 +0000
commitad481c475fc828896c5db2f067286c9dad50da2a (patch)
treef5a6c405d2c545f35528ae56f3c67ef65f088cc9
parent86a241e90cc164cf28d10ce8430c7dbe7eef0bdb (diff)
downloadcoreboot-ad481c475fc828896c5db2f067286c9dad50da2a.tar.xz
mb/google/zork: set APU_EDP_BL_DISABLE to low as default
set APU_EDP_BL_DISABLE(GPIO_85) to low to avoid the VARY_BL fast than APU_DP_BLON. BUG=b:171954512 BRANCH=zork TEST=validate the panel sequence with scope. Signed-off-by: Chris Wang <chris.wang@amd.corp-partner.google.com> Change-Id: Ia6d3f4335583bb2d91a6bce96d89cff84247d0ad Reviewed-on: https://review.coreboot.org/c/coreboot/+/48203 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Kangheui Won <khwon@chromium.org>
-rw-r--r--src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c4
-rw-r--r--src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c4
2 files changed, 4 insertions, 4 deletions
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
index a528827879..bf27abf953 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
@@ -95,8 +95,8 @@ static const struct soc_amd_gpio gpio_set_stage_ram[] = {
/* GPIO_77 - GPIO_83: Not available */
/* HP_INT_ODL */
PAD_GPI(GPIO_84, PULL_NONE),
- /* APU_EDP_BL_DISABLE TODP: Set low in depthcharge */
- PAD_GPO(GPIO_85, HIGH),
+ /* APU_EDP_BL_DISABLE */
+ PAD_GPO(GPIO_85, LOW),
/* RAM ID 2 - Keep High */
PAD_GPO(GPIO_86, HIGH),
/* EMMC_DATA7 */
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
index 2929c54cdc..0745edae20 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
@@ -99,8 +99,8 @@ static const struct soc_amd_gpio gpio_set_stage_ram[] = {
/* GPIO_77 - GPIO_83: Not available */
/* RAM_ID_4 */
PAD_GPI(GPIO_84, PULL_NONE),
- /* APU_EDP_BL_DISABLE TODP: Set low in depthcharge */
- PAD_GPO(GPIO_85, HIGH),
+ /* APU_EDP_BL_DISABLE */
+ PAD_GPO(GPIO_85, LOW),
/* WIFI_AUX_RESET_L */
PAD_GPO(GPIO_86, HIGH),
/* EMMC_DATA7 */