diff options
| author | Martin Roth <martinroth@google.com> | 2015-11-23 16:34:10 -0700 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2015-11-24 21:05:45 +0100 |
| commit | b9434aa853d75d38a5e051ca9a516621e9ca3605 (patch) | |
| tree | 91223fbbd3e00b5618457ca1c2dd117d32ae20ef | |
| parent | f5fd4c99d5b05fd9677cf81124d5ad5ef2270011 (diff) | |
| download | coreboot-b9434aa853d75d38a5e051ca9a516621e9ca3605.tar.xz | |
intel/d945gclf: Fix IASL warning and remark
- Add an empty Operating Region for the empty _REG method
- Serialize _CRS Method
- Remove Kconfig default disabling IASL warnings as errors
dsdt.aml 1445: Method (_CRS, 0)
Remark 2120 - ^ Control Method should be made Serialized
(due to creation of named objects within)
dsdt.aml 1454: Method (_REG, 2)
Warning 3079 - ^ _REG has no corresponding Operation Region
Change-Id: I2b64609c929af62c2b699762206e5baf58fbdb8b
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: http://review.coreboot.org/12523
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
| -rw-r--r-- | src/mainboard/intel/d945gclf/Kconfig | 4 | ||||
| -rw-r--r-- | src/mainboard/intel/d945gclf/acpi/ec.asl | 8 |
2 files changed, 7 insertions, 5 deletions
diff --git a/src/mainboard/intel/d945gclf/Kconfig b/src/mainboard/intel/d945gclf/Kconfig index 2023216be4..429a3040f2 100644 --- a/src/mainboard/intel/d945gclf/Kconfig +++ b/src/mainboard/intel/d945gclf/Kconfig @@ -50,8 +50,4 @@ config MAX_CPUS int default 4 -# TODO: Remove this when platform ASL is fixed -config IASL_WARNINGS_ARE_ERRORS - def_bool n - endif # BOARD_INTEL_D945GCLF diff --git a/src/mainboard/intel/d945gclf/acpi/ec.asl b/src/mainboard/intel/d945gclf/acpi/ec.asl index 45e2bd10aa..5362bb2e59 100644 --- a/src/mainboard/intel/d945gclf/acpi/ec.asl +++ b/src/mainboard/intel/d945gclf/acpi/ec.asl @@ -18,7 +18,13 @@ Device(EC0) Name (_HID, EISAID("PNP0C09")) Name (_UID, 1) - Method (_CRS, 0) + // _REG method requires that an operation region be defined. + OperationRegion (ERAM, EmbeddedControl, 0x00, 0xff) + Field (ERAM, ByteAcc, Lock, Preserve) + { + } + + Method (_CRS, 0, Serialized) { Name (ECMD, ResourceTemplate() { |