diff options
| author | Patrick Georgi <pgeorgi@chromium.org> | 2016-08-02 14:28:49 +0200 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2016-08-03 22:53:21 +0200 |
| commit | b9eee8e468a78789dce8d5af12274fc0dc2d5007 (patch) | |
| tree | 67c3b4d2141e0106b231c03aefa510c2fba7851e | |
| parent | d6319e8cc08995564d9834a654c78c3d5e111822 (diff) | |
| download | coreboot-b9eee8e468a78789dce8d5af12274fc0dc2d5007.tar.xz | |
lenovo/x60: Fetch 16 bits when trying to parse bit 13
I'm not sure if that's the right fix here, but assuming the bit mask is
right, the inb is wrong.
Change-Id: I7e33019af088780a09be12513200bec63734bf97
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Found-by: Coverity Scan #1229556
Reviewed-on: https://review.coreboot.org/16026
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Alexander Couzens <lynxis@fe80.eu>
| -rw-r--r-- | src/mainboard/lenovo/x60/dock.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/lenovo/x60/dock.c b/src/mainboard/lenovo/x60/dock.c index ca82d388ab..c2bed9a087 100644 --- a/src/mainboard/lenovo/x60/dock.c +++ b/src/mainboard/lenovo/x60/dock.c @@ -255,7 +255,7 @@ void dock_disconnect(void) int dock_present(void) { - return !((inb(DEFAULT_GPIOBASE + 0x0c) >> 13) & 1); + return !((inw(DEFAULT_GPIOBASE + 0x0c) >> 13) & 1); } int dock_ultrabay_device_present(void) |