summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2019-01-14 23:45:46 +0100
committerPatrick Georgi <pgeorgi@google.com>2019-01-16 16:46:00 +0000
commitbd294425c8f0ac22103989ebbbdbcf9c84ecc789 (patch)
treecd6d66b43ddfa7e7d9adf6d55de2898c39e7028a
parenta6be58fecec5e01a809ced3c87d6c24db4e2a91d (diff)
downloadcoreboot-bd294425c8f0ac22103989ebbbdbcf9c84ecc789.tar.xz
mb/purism: Select NO_POST instead of overriding its dependencies
Declaring a Kconfig symbol ahead to override its default also always sets implicit dependencies. If the original symbol doesn't have any, Kconfig gets confused. Change-Id: Ie6d9ca96e4b6037eefd432dd386cb5e540deb0ed Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/30925 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rw-r--r--src/mainboard/purism/librem_bdw/Kconfig7
-rw-r--r--src/mainboard/purism/librem_skl/Kconfig7
2 files changed, 2 insertions, 12 deletions
diff --git a/src/mainboard/purism/librem_bdw/Kconfig b/src/mainboard/purism/librem_bdw/Kconfig
index f9016b913e..7f7519c73e 100644
--- a/src/mainboard/purism/librem_bdw/Kconfig
+++ b/src/mainboard/purism/librem_bdw/Kconfig
@@ -7,6 +7,7 @@ config BOARD_PURISM_BASEBOARD_LIBREM_BDW
select HAVE_ACPI_TABLES
select INTEL_INT15
select SOC_INTEL_BROADWELL
+ select NO_POST # This platform does not have any way to see POST codes
if BOARD_PURISM_BASEBOARD_LIBREM_BDW
@@ -63,12 +64,6 @@ config MAX_CPUS
int
default 8
-config NO_POST
- def_bool y
- help
- This platform does not have any way to see POST codes
- so disable them by default.
-
config PRE_GRAPHICS_DELAY
int
default 50
diff --git a/src/mainboard/purism/librem_skl/Kconfig b/src/mainboard/purism/librem_skl/Kconfig
index 12d4bcb046..224779d5e8 100644
--- a/src/mainboard/purism/librem_skl/Kconfig
+++ b/src/mainboard/purism/librem_skl/Kconfig
@@ -11,6 +11,7 @@ config BOARD_PURISM_BASEBOARD_LIBREM_SKL
select MAINBOARD_USES_FSP2_0
select SPD_READ_BY_WORD
select MAINBOARD_HAS_LPC_TPM
+ select NO_POST # This platform does not have any way to see POST codes
if BOARD_PURISM_BASEBOARD_LIBREM_SKL
@@ -54,12 +55,6 @@ config MAX_CPUS
int
default 8
-config NO_POST
- def_bool y
- help
- This platform does not have any way to see POST codes
- so disable them by default.
-
config VGA_BIOS_ID
string
default "8086,1916"