summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoe Moore <awokd@danwin1210.me>2019-11-25 05:49:30 -0700
committerPatrick Georgi <pgeorgi@google.com>2020-03-04 16:07:29 +0000
commitc156b584ee820a703073ceda3eaf6cec6afc9966 (patch)
tree34b73e14293831aa9fcb4f050cb3cd69e8e81544
parent53e282acc04d7a8de6ddf5c9453666c02f4d8c43 (diff)
downloadcoreboot-c156b584ee820a703073ceda3eaf6cec6afc9966.tar.xz
vc/amd/agesa: Fix uninitialized scalar variable
AllocParams.Persist is used uninitialized when calling HeapAllocateBuffer. This could lead to unpredictable or unintended results. The f15tn and f16 versions of AmdS3Save.c have already addressed this by initializing AllocParams.Persist=0 in the same location in the code, so adding to f14 only. Change-Id: I2cbfbc4ad14a861e0cd92f130209b3b0f5b76a17 Signed-off-by: Joe Moore <awokd@danwin1210.me> Found-by: Coverity CID 1241806 Reviewed-on: https://review.coreboot.org/c/coreboot/+/37194 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi@google.com> Reviewed-by: Frans Hendriks <fhendriks@eltan.com>
-rw-r--r--src/vendorcode/amd/agesa/f14/Proc/Common/AmdS3Save.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/vendorcode/amd/agesa/f14/Proc/Common/AmdS3Save.c b/src/vendorcode/amd/agesa/f14/Proc/Common/AmdS3Save.c
index eeab385430..bc5102bbd5 100644
--- a/src/vendorcode/amd/agesa/f14/Proc/Common/AmdS3Save.c
+++ b/src/vendorcode/amd/agesa/f14/Proc/Common/AmdS3Save.c
@@ -202,7 +202,7 @@ AmdS3Save (
//
AllocParams.RequestedBufferSize = EarlyBufferSize + LateBufferSize;
AllocParams.BufferHandle = AMD_S3_INFO_BUFFER_HANDLE;
-
+ AllocParams.Persist = 0;
AGESA_TESTPOINT (TpIfBeforeAllocateS3SaveBuffer, &AmdS3SaveParams->StdHeader);
if (HeapAllocateBuffer (&AllocParams, &AmdS3SaveParams->StdHeader) != AGESA_SUCCESS) {
if (AGESA_ERROR > ReturnStatus) {