diff options
| author | Aaron Durbin <adurbin@chromium.org> | 2020-01-28 11:00:51 -0700 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2020-01-31 17:12:01 +0000 |
| commit | c3488988b8813dd934e4e29c664283a335affc6d (patch) | |
| tree | 9e59695b8ba8d1e636be3c90884164295776c670 | |
| parent | 3bee7df954fd4285f8445c54de90b8a12fdbc9fd (diff) | |
| download | coreboot-c3488988b8813dd934e4e29c664283a335affc6d.tar.xz | |
soc/amd/picasso: use SMBus timeout in compilation unit
The timeout is fixed and only used in one place. Put the assumption
in the compliation unit utilizing the defintion.
Change-Id: I93c061e74df6b4265fd1c61fc4669410ebc9554f
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38614
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
| -rw-r--r-- | src/soc/amd/picasso/include/soc/smbus.h | 6 | ||||
| -rw-r--r-- | src/soc/amd/picasso/smbus.c | 6 |
2 files changed, 6 insertions, 6 deletions
diff --git a/src/soc/amd/picasso/include/soc/smbus.h b/src/soc/amd/picasso/include/soc/smbus.h index 60b8bfa055..524be7791d 100644 --- a/src/soc/amd/picasso/include/soc/smbus.h +++ b/src/soc/amd/picasso/include/soc/smbus.h @@ -19,12 +19,6 @@ #include <stdint.h> #include <soc/iomap.h> -/* - * Between 1-10 seconds, We should never timeout normally - * Longer than this is just painful when a timeout condition occurs. - */ -#define SMBUS_TIMEOUT (100 * 1000 * 10) - int do_smbus_read_byte(u32 mmio, u8 device, u8 address); int do_smbus_write_byte(u32 mmio, u8 device, u8 address, u8 val); int do_smbus_recv_byte(u32 mmio, u8 device); diff --git a/src/soc/amd/picasso/smbus.c b/src/soc/amd/picasso/smbus.c index 79f09d6b88..f5a9d604ea 100644 --- a/src/soc/amd/picasso/smbus.c +++ b/src/soc/amd/picasso/smbus.c @@ -19,6 +19,12 @@ #include <soc/smbus.h> #include <soc/southbridge.h> +/* + * Between 1-10 seconds, We should never timeout normally + * Longer than this is just painful when a timeout condition occurs. + */ +#define SMBUS_TIMEOUT (100 * 1000 * 10) + static u8 controller_read8(u32 base, u8 reg) { switch (base) { |