summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndy Yeh <andy.yeh@intel.com>2018-01-29 15:18:32 +0800
committerFurquan Shaikh <furquan@google.com>2018-02-06 01:06:58 +0000
commitc4f94b1a7514b58388d347e79575b547eb82d08f (patch)
tree6fa10033ef0c47b62142bda1b5d45a1a62bbd0da
parent0592776467012a371655ccfaa0a4e708be904b2c (diff)
downloadcoreboot-c4f94b1a7514b58388d347e79575b547eb82d08f.tar.xz
mb/google/nautilus: Work around the power issue of MIPI and USB cameras
On EVT, the USB and MIPI cameras share the same power source. As a result, when the MIPI camera driver turns off the camera once probed, USB camera will be disconnected. To make USB camera work on EVT devices, we will need a hack in coreboot to leave the camera power always-on. BUG=b:72839352 TEST: Verified the MIPI and USB camera function on DUT board TODO: This power issue will be fixed on DVT build. Will revert this patch once confirmed power sources for MIPI and USB camera could be supplied individually. Change-Id: Icaaf7e17447492f2e2f2d03eb9a35bcc53667f28 Signed-off-by: Andy Yeh <andy.yeh@intel.com> Reviewed-on: https://review.coreboot.org/23546 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Andy Yeh
-rw-r--r--src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
index 5eaf5b758a..b74fba98d9 100644
--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
@@ -39,7 +39,14 @@ Scope (\_SB.PCI0.I2C2)
Method (PMOF, 0, Serialized) {
/* Make Sure all PMIC outputs are off. */
If (LEqual (VSIC, Zero)) {
+ /*
+ * On Nautilus Pre-EVT/EVT, the USB and MIPI share the
+ * same power source, before HW fix in DVT, temporarily
+ * disabled turn off 3V3_VDD
+ */
+#if !IS_ENABLED(CONFIG_BOARD_GOOGLE_NAUTILUS)
CTXS(EN_PP3300_DX_CAM)
+#endif
}
}