summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDuncan Laurie <dlaurie@google.com>2019-01-07 12:02:23 -0800
committerDuncan Laurie <dlaurie@chromium.org>2019-01-08 19:13:03 +0000
commitcae7944fc310be9ef6b0c105d5a6a3e9b113e507 (patch)
treee7c7ba2b1805eb6b5034dcbef688c76ec022aa3c
parente11aeab132960890998d56e17bcfae594541ded5 (diff)
downloadcoreboot-cae7944fc310be9ef6b0c105d5a6a3e9b113e507.tar.xz
mb/google/sarien: Enable recovery mode GPIO
Enable the active-low recovery mode GPIO now that new boards are available which have an external pull-up instead of a pull-down so it can be asserted properly by servo. This was tested on a Sarien system by holding the recovery button on the servo board and tapping the cold reset button and ensuring that it enters recovery mode. Change-Id: I3216580bc94de71b05bf9382f15d0c4d428cb9fa Signed-off-by: Duncan Laurie <dlaurie@google.com> Reviewed-on: https://review.coreboot.org/c/30721 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
-rw-r--r--src/mainboard/google/sarien/variants/sarien/gpio.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/mainboard/google/sarien/variants/sarien/gpio.c b/src/mainboard/google/sarien/variants/sarien/gpio.c
index 3f43e73422..f773265d31 100644
--- a/src/mainboard/google/sarien/variants/sarien/gpio.c
+++ b/src/mainboard/google/sarien/variants/sarien/gpio.c
@@ -252,10 +252,7 @@ const struct pad_config *variant_early_gpio_table(size_t *num)
}
static const struct cros_gpio cros_gpios[] = {
- /*
- * TODO: re-enable recovery mode when boards are updated:
- * CROS_GPIO_REC_AL(GPP_E8, CROS_GPIO_DEVICE_NAME),
- */
+ CROS_GPIO_REC_AL(GPP_E8, CROS_GPIO_DEVICE_NAME),
CROS_GPIO_WP_AH(GPP_E15, CROS_GPIO_DEVICE_NAME),
};