diff options
| author | Matt DeVillier <matt.devillier@gmail.com> | 2017-11-04 12:33:41 -0500 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-11-23 05:02:35 +0000 |
| commit | d18db73d4997b08606d5186eee58f38c400281b6 (patch) | |
| tree | f9f82ec2136de7661e3ee95ad98b49ec5849622b | |
| parent | 482d16fb0ab1899da856b083f35b682917b0ed96 (diff) | |
| download | coreboot-d18db73d4997b08606d5186eee58f38c400281b6.tar.xz | |
google mainboards: select SYSTEM_TYPE_LAPTOP where appropriate
Some Google boards are missing this selection, leading them to being
incorrectly identified as type 'Desktop' in SMBIOS type 3 table.
Correct this by adding 'select SYSTEM_TYPE_LAPTOP' to the boards'
Kconfigs.
TEST: boot Linux and check correct chassis type listed via dmidecode
Change-Id: Ib1145e314812a3f300cfd1a435a687aa0862158a
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/22340
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
| -rw-r--r-- | src/mainboard/google/auron/Kconfig | 1 | ||||
| -rw-r--r-- | src/mainboard/google/chell/Kconfig | 1 | ||||
| -rw-r--r-- | src/mainboard/google/cyan/Kconfig | 1 | ||||
| -rw-r--r-- | src/mainboard/google/glados/Kconfig | 1 | ||||
| -rw-r--r-- | src/mainboard/google/lars/Kconfig | 1 | ||||
| -rw-r--r-- | src/mainboard/google/rambi/Kconfig | 1 |
6 files changed, 6 insertions, 0 deletions
diff --git a/src/mainboard/google/auron/Kconfig b/src/mainboard/google/auron/Kconfig index 8cf7e8f968..791dcba5ef 100644 --- a/src/mainboard/google/auron/Kconfig +++ b/src/mainboard/google/auron/Kconfig @@ -11,6 +11,7 @@ config BOARD_GOOGLE_BASEBOARD_AURON select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select INTEL_INT15 + select SYSTEM_TYPE_LAPTOP if BOARD_GOOGLE_BASEBOARD_AURON diff --git a/src/mainboard/google/chell/Kconfig b/src/mainboard/google/chell/Kconfig index 277c98f4c1..c09ad48331 100644 --- a/src/mainboard/google/chell/Kconfig +++ b/src/mainboard/google/chell/Kconfig @@ -19,6 +19,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select SOC_INTEL_SKYLAKE + select SYSTEM_TYPE_LAPTOP config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig index 0ecb317196..7b8fd44aa0 100644 --- a/src/mainboard/google/cyan/Kconfig +++ b/src/mainboard/google/cyan/Kconfig @@ -13,6 +13,7 @@ config BOARD_GOOGLE_BASEBOARD_CYAN select SOC_INTEL_BRASWELL select HAVE_ACPI_RESUME select PCIEXP_L1_SUB_STATE if !BOARD_GOOGLE_CYAN + select SYSTEM_TYPE_LAPTOP if BOARD_GOOGLE_BASEBOARD_CYAN diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig index 1a19fd1bfa..b893a6a966 100644 --- a/src/mainboard/google/glados/Kconfig +++ b/src/mainboard/google/glados/Kconfig @@ -19,6 +19,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select SOC_INTEL_SKYLAKE + select SYSTEM_TYPE_LAPTOP config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES diff --git a/src/mainboard/google/lars/Kconfig b/src/mainboard/google/lars/Kconfig index 4a49460b04..e274b13e14 100644 --- a/src/mainboard/google/lars/Kconfig +++ b/src/mainboard/google/lars/Kconfig @@ -21,6 +21,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select SOC_INTEL_SKYLAKE + select SYSTEM_TYPE_LAPTOP config VBOOT select EC_GOOGLE_CHROMEEC_SWITCHES diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index c1b0ca2e25..3db8ac6c8d 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -10,6 +10,7 @@ config BOARD_GOOGLE_BASEBOARD_RAMBI select HAVE_ACPI_RESUME select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM + select SYSTEM_TYPE_LAPTOP if !BOARD_GOOGLE_NINJA && !BOARD_GOOGLE_SUMO if BOARD_GOOGLE_BASEBOARD_RAMBI |