summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Lemenkov <lemenkov@gmail.com>2019-10-22 19:08:59 +0200
committerPatrick Georgi <pgeorgi@google.com>2019-10-25 07:02:50 +0000
commitdbed7865d34d407814bc59dae06e93be3a3fcf95 (patch)
tree8c1c02dccb7797f4f1834c862766e7bbcf6eefc2
parentcfc93cbb660e2092374151dc616be0798854378e (diff)
downloadcoreboot-dbed7865d34d407814bc59dae06e93be3a3fcf95.tar.xz
mb/*/*/smihandler: Remove bogus mainboard_io_trap_handler
These mainboard_io_trap_handler functions do nothing compared to a weak mainboard_io_trap_handler in src/cpu/x86/smm/. Change-Id: I73ebcc6c3f604a075a946503d51881ccc6820dac Signed-off-by: Peter Lemenkov <lemenkov@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/36245 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Rudolph <siro@das-labor.org>
-rw-r--r--src/mainboard/apple/macbook21/smihandler.c12
-rw-r--r--src/mainboard/lenovo/s230u/smihandler.c5
-rw-r--r--src/mainboard/packardbell/ms2290/smihandler.c13
3 files changed, 0 insertions, 30 deletions
diff --git a/src/mainboard/apple/macbook21/smihandler.c b/src/mainboard/apple/macbook21/smihandler.c
index adb48db6dc..6e8601b434 100644
--- a/src/mainboard/apple/macbook21/smihandler.c
+++ b/src/mainboard/apple/macbook21/smihandler.c
@@ -21,18 +21,6 @@
#define GPE_EC_SCI 12
-int mainboard_io_trap_handler(int smif)
-{
- switch (smif) {
- default:
- return 0;
- }
-
- /* On success, the IO Trap Handler returns 1
- * On failure, the IO Trap Handler returns a value != 1 */
- return 1;
-}
-
int mainboard_smi_apmc(u8 data)
{
switch (data) {
diff --git a/src/mainboard/lenovo/s230u/smihandler.c b/src/mainboard/lenovo/s230u/smihandler.c
index 1abf0c88a7..668fe697dd 100644
--- a/src/mainboard/lenovo/s230u/smihandler.c
+++ b/src/mainboard/lenovo/s230u/smihandler.c
@@ -32,11 +32,6 @@
/* FIXME: check this */
#define GPE_EC_WAKE 13
-int mainboard_io_trap_handler(int smif)
-{
- return 0;
-}
-
enum sleep_states {
S0 = 0,
S1 = 1,
diff --git a/src/mainboard/packardbell/ms2290/smihandler.c b/src/mainboard/packardbell/ms2290/smihandler.c
index 915de13de1..bc5067be1e 100644
--- a/src/mainboard/packardbell/ms2290/smihandler.c
+++ b/src/mainboard/packardbell/ms2290/smihandler.c
@@ -22,19 +22,6 @@
#include <northbridge/intel/nehalem/nehalem.h>
#include <ec/acpi/ec.h>
-int mainboard_io_trap_handler(int smif)
-{
- switch (smif) {
-
- default:
- return 0;
- }
-
- /* On success, the IO Trap Handler returns 1
- * On failure, the IO Trap Handler returns a value != 1 */
- return 1;
-}
-
void mainboard_smi_gpi(u32 gpi_sts)
{
}