summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniele Forsi <dforsi@gmail.com>2014-07-27 11:02:15 +0200
committerPatrick Georgi <patrick@georgi-clan.de>2014-07-30 13:16:55 +0200
commitddf54b1c8b2ef6e8e3d2a673e0dd1ab43c7edc2c (patch)
treead42d2b8978a6b551e1400e03f8845ca8b9937a6
parent201093ef6d24de27bc491947b9ab31d22f0aca8f (diff)
downloadcoreboot-ddf54b1c8b2ef6e8e3d2a673e0dd1ab43c7edc2c.tar.xz
util/sconfig: fix check for count of command line arguments
Valid invocations are when -s|b|k outputfile is missing (argc == 3) and when it is followed by the file name (argc == 5); it's an error when "outputfile" is missing (argc == 4) or when there are more arguments than expected (argc > 5). Fixes "Uninitialized argument value" error found by scan-build from clang version 3.2-11. Change-Id: I8c489863323eb60cbaa5e82a80f5d78a6ca893c2 Signed-off-by: Daniele Forsi <dforsi@gmail.com> Reviewed-on: http://review.coreboot.org/6378 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Patrick Georgi <patrick@georgi-clan.de> Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
-rw-r--r--util/sconfig/main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/util/sconfig/main.c b/util/sconfig/main.c
index 74193e6740..f6ec0e200b 100644
--- a/util/sconfig/main.c
+++ b/util/sconfig/main.c
@@ -557,7 +557,7 @@ static void usage(void)
int main(int argc, char** argv) {
- if (argc < 3)
+ if (argc != 3 && argc != 5)
usage();
char *mainboard=argv[1];