diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2016-08-19 23:41:32 +0300 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2016-09-07 23:06:31 +0200 |
| commit | e0d7e2690fd3aff73283a885cb9d077ea3830aba (patch) | |
| tree | 5856308172da14b939467c2311163ff1858a2be8 | |
| parent | e8cf4ffbee7fc1b8a4c98ded8ac148a2041fc81d (diff) | |
| download | coreboot-e0d7e2690fd3aff73283a885cb9d077ea3830aba.tar.xz | |
intel/i82801gx 82801ix: Remove OpRegion of SMBus host
Defining this OpRegion for SMBus controller prevents linux kernel
driver i2c-i801 from registering SMBus under sysfs, with following
error in dmesg:
ACPI Warning: SystemIO range .. conflicts with OpRegion .. (\_SB.PCI0.SBUS.SMBI)
Solution taken from intel/bd82x6x. Worth noting we do not
define ENABLE_SMBUS_METHODS anywhere currently.
Removed remaining reference to HSTS from GETAC P470.
Change-Id: I7c13d344b0343387681b46019cc5061b1435b46b
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Signed-off-by: Damien Zammit <damien@zamaudio.com>
Reviewed-on: https://review.coreboot.org/16266
Tested-by: build bot (Jenkins)
Reviewed-by: Nico Huber <nico.h@gmx.de>
| -rw-r--r-- | src/mainboard/getac/p470/acpi/gpe.asl | 2 | ||||
| -rw-r--r-- | src/southbridge/intel/i82801gx/acpi/smbus.asl | 2 | ||||
| -rw-r--r-- | src/southbridge/intel/i82801ix/acpi/smbus.asl | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/mainboard/getac/p470/acpi/gpe.asl b/src/mainboard/getac/p470/acpi/gpe.asl index 661fa44faa..dcf8e99b5f 100644 --- a/src/mainboard/getac/p470/acpi/gpe.asl +++ b/src/mainboard/getac/p470/acpi/gpe.asl @@ -56,7 +56,7 @@ Scope (_GPE) // SMBus (Reserved!) Method (_L07, 0) { - Store (0x20, \_SB.PCI0.SBUS.HSTS) + // Store (0x20, \_SB.PCI0.SBUS.HSTS) } // COM1/COM2 (RI) diff --git a/src/southbridge/intel/i82801gx/acpi/smbus.asl b/src/southbridge/intel/i82801gx/acpi/smbus.asl index 3c4337fe89..3b314e4054 100644 --- a/src/southbridge/intel/i82801gx/acpi/smbus.asl +++ b/src/southbridge/intel/i82801gx/acpi/smbus.asl @@ -20,6 +20,7 @@ Device (SBUS) { Name (_ADR, 0x001f0003) +#ifdef ENABLE_SMBUS_METHODS OperationRegion (SMBP, PCI_Config, 0x00, 0x100) Field(SMBP, DWordAcc, NoLock, Preserve) { @@ -53,7 +54,6 @@ Device (SBUS) NDLH, 8, // Notify Data High Byte } -#ifdef ENABLE_SMBUS_METHODS // Kill all SMBus communication Method (KILL, 0, Serialized) { diff --git a/src/southbridge/intel/i82801ix/acpi/smbus.asl b/src/southbridge/intel/i82801ix/acpi/smbus.asl index 3c4337fe89..3b314e4054 100644 --- a/src/southbridge/intel/i82801ix/acpi/smbus.asl +++ b/src/southbridge/intel/i82801ix/acpi/smbus.asl @@ -20,6 +20,7 @@ Device (SBUS) { Name (_ADR, 0x001f0003) +#ifdef ENABLE_SMBUS_METHODS OperationRegion (SMBP, PCI_Config, 0x00, 0x100) Field(SMBP, DWordAcc, NoLock, Preserve) { @@ -53,7 +54,6 @@ Device (SBUS) NDLH, 8, // Notify Data High Byte } -#ifdef ENABLE_SMBUS_METHODS // Kill all SMBus communication Method (KILL, 0, Serialized) { |