summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>2020-06-19 19:09:51 +0800
committerPatrick Georgi <pgeorgi@google.com>2020-06-25 11:53:12 +0000
commiteba0433b1707904507bd62cf547450d9e2fd203e (patch)
tree18287d5f40e90eeaadc6712d452f6b5cf7c4d4e8
parent2ef3b2df1f562610219444d913224d0600c097a1 (diff)
downloadcoreboot-eba0433b1707904507bd62cf547450d9e2fd203e.tar.xz
mb/google/octopus/variants/bobba: fix disable_xhci_lfps_pm by sku
due to overridetree.cb set disable_xhci_lfps_pm = 0, need correct condition expression to let function work. BUG=b:146768983 BRANCH=octopus TEST=build coreboot with DisableXhciLfpsPM being set to 1 and flash the image to the device. Run following command to check if bits[7:4] is set 0: >iotools mmio_read32 "XHCI MMIO BAR + 0x80A4" Signed-off-by: Pan Sheng-Liang <sheng-liang.pan@quanta.corp-partner.google.com> Change-Id: I53621d7674a531adfa40e8703cb2cd01c50376b8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42564 Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Henry Sun <henrysun@google.com> Reviewed-by: Marco Chen <marcochen@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/mainboard/google/octopus/variants/bobba/variant.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/google/octopus/variants/bobba/variant.c b/src/mainboard/google/octopus/variants/bobba/variant.c
index f011b65ab1..97c77a95dc 100644
--- a/src/mainboard/google/octopus/variants/bobba/variant.c
+++ b/src/mainboard/google/octopus/variants/bobba/variant.c
@@ -82,7 +82,7 @@ void variant_update_devtree(struct device *dev)
cfg = (struct soc_intel_apollolake_config *)dev->chip_info;
- if (cfg != NULL && cfg->disable_xhci_lfps_pm) {
+ if (cfg != NULL && (cfg->disable_xhci_lfps_pm != 1)) {
switch (google_chromeec_get_board_sku()) {
case 37:
case 38: