diff options
| author | Keith Hui <buurin@gmail.com> | 2020-05-02 15:24:28 -0400 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2020-05-11 09:28:35 +0000 |
| commit | f5472a10c6fc3f0c452c514c7a23b7046e42ac55 (patch) | |
| tree | 3881f51261354e8a9f19719b1c926b84275ff11e | |
| parent | c844d14ca5081b2cb2f1036bdf0c2112405342d1 (diff) | |
| download | coreboot-f5472a10c6fc3f0c452c514c7a23b7046e42ac55.tar.xz | |
superio/winbond/w83977tf: Only list IR logical device if needed
Really old versions of W83977TF Super I/O had an IR logical device, but
is no longer the case. It does not exist in the newer W83977EF version,
installed in some Asus P2B family boards, and served by this same code.
Add a config option on the off chance we may see board with it (as if
we would) and don't include this device unless it is set. Saves us from
the need to declare a not-present device off and/or extraneous PNP
device errors about a not-present device.
Change-Id: I761ebc41f1735a03e768339a68ca139167edc095
Signed-off-by: Keith Hui <buurin@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41004
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/superio/winbond/w83977tf/Kconfig | 6 | ||||
| -rw-r--r-- | src/superio/winbond/w83977tf/superio.c | 2 |
2 files changed, 8 insertions, 0 deletions
diff --git a/src/superio/winbond/w83977tf/Kconfig b/src/superio/winbond/w83977tf/Kconfig index d656b67884..e7f25ab1e7 100644 --- a/src/superio/winbond/w83977tf/Kconfig +++ b/src/superio/winbond/w83977tf/Kconfig @@ -4,3 +4,9 @@ config SUPERIO_WINBOND_W83977TF bool select SUPERIO_WINBOND_COMMON_PRE_RAM + +config W83977TF_HAVE_SEPARATE_IR_DEVICE + bool + help + Mainboard should select this option if it contains an old + version of W83977TF with a separate IR logical device. diff --git a/src/superio/winbond/w83977tf/superio.c b/src/superio/winbond/w83977tf/superio.c index b56bb9c325..04b26e0f60 100644 --- a/src/superio/winbond/w83977tf/superio.c +++ b/src/superio/winbond/w83977tf/superio.c @@ -37,7 +37,9 @@ static struct pnp_info pnp_dev_info[] = { { NULL, W83977TF_SP2, PNP_IO0 | PNP_IRQ0, 0x07f8, }, { NULL, W83977TF_KBC, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_IRQ1, 0x07ff, 0x07ff, }, +#if CONFIG(W83977TF_HAVE_SEPARATE_IR_DEVICE) { NULL, W83977TF_CIR, PNP_IO0 | PNP_IRQ0, 0x07f8, }, +#endif { NULL, W83977TF_GAME_MIDI_GPIO1, PNP_IO0 | PNP_IO1 | PNP_IRQ0, 0x07ff, 0x07fe, }, { NULL, W83977TF_ACPI, PNP_IRQ0, }, |