summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSubrata Banik <subrata.banik@intel.com>2019-05-06 19:23:26 +0530
committerSubrata Banik <subrata.banik@intel.com>2019-05-21 16:20:56 +0000
commitf91344cd07a4e9a4c2e183f00431b4fee05daf33 (patch)
tree0fc15361188e221582a46f4c2b01ba5841fea3f5
parent7196be433efc05c8a74b2b82a7689d03d46f2d77 (diff)
downloadcoreboot-f91344cd07a4e9a4c2e183f00431b4fee05daf33.tar.xz
soc/intel: Remove unused pointer argument in mca_configure()
Change-Id: Iad3982d9db07a1f17ac39e87ff9c37956e40c258 Signed-off-by: Subrata Banik <subrata.banik@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32616 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Rudolph <siro@das-labor.org> Reviewed-by: David Guckian Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
-rw-r--r--src/soc/intel/apollolake/cpu.c2
-rw-r--r--src/soc/intel/cannonlake/cpu.c2
-rw-r--r--src/soc/intel/common/block/cpu/cpulib.c2
-rw-r--r--src/soc/intel/common/block/include/intelblocks/cpulib.h2
-rw-r--r--src/soc/intel/denverton_ns/cpu.c2
-rw-r--r--src/soc/intel/icelake/cpu.c2
-rw-r--r--src/soc/intel/skylake/cpu.c2
7 files changed, 7 insertions, 7 deletions
diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c
index 651c20e43a..aad0f6b522 100644
--- a/src/soc/intel/apollolake/cpu.c
+++ b/src/soc/intel/apollolake/cpu.c
@@ -76,7 +76,7 @@ void soc_core_init(struct device *cpu)
scope. For now every CPU clears every bank. */
if (CONFIG(SOC_INTEL_COMMON_BLOCK_SGX) ||
acpi_get_sleep_type() == ACPI_S5)
- mca_configure(NULL);
+ mca_configure();
/* Set core MSRs */
reg_script_run(core_msr_script);
diff --git a/src/soc/intel/cannonlake/cpu.c b/src/soc/intel/cannonlake/cpu.c
index 8552424749..d98e2f5486 100644
--- a/src/soc/intel/cannonlake/cpu.c
+++ b/src/soc/intel/cannonlake/cpu.c
@@ -413,7 +413,7 @@ void soc_core_init(struct device *cpu)
/* TODO(adurbin): This should only be done on a cold boot. Also, some
* of these banks are core vs package scope. For now every CPU clears
* every bank. */
- mca_configure(NULL);
+ mca_configure();
/* Enable the local CPU apics */
enable_lapic_tpr();
diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c
index a7f89baafd..75e71120e0 100644
--- a/src/soc/intel/common/block/cpu/cpulib.c
+++ b/src/soc/intel/common/block/cpu/cpulib.c
@@ -300,7 +300,7 @@ uint32_t cpu_get_max_turbo_ratio(void)
return msr.lo & 0xff;
}
-void mca_configure(void *unused)
+void mca_configure(void)
{
msr_t msr;
int i;
diff --git a/src/soc/intel/common/block/include/intelblocks/cpulib.h b/src/soc/intel/common/block/include/intelblocks/cpulib.h
index 70ad253607..8630fd1eb5 100644
--- a/src/soc/intel/common/block/include/intelblocks/cpulib.h
+++ b/src/soc/intel/common/block/include/intelblocks/cpulib.h
@@ -159,6 +159,6 @@ uint32_t cpu_get_power_max(void);
uint32_t cpu_get_max_turbo_ratio(void);
/* Configure Machine Check Architecture support */
-void mca_configure(void *unused);
+void mca_configure(void);
#endif /* SOC_INTEL_COMMON_BLOCK_CPULIB_H */
diff --git a/src/soc/intel/denverton_ns/cpu.c b/src/soc/intel/denverton_ns/cpu.c
index ce6df68f9f..2a631718c0 100644
--- a/src/soc/intel/denverton_ns/cpu.c
+++ b/src/soc/intel/denverton_ns/cpu.c
@@ -58,7 +58,7 @@ static void dnv_configure_mca(void)
/* TODO(adurbin): This should only be done on a cold boot. Also, some
of these banks are core vs package scope. For now every CPU clears
every bank. */
- mca_configure(NULL);
+ mca_configure();
}
static void denverton_core_init(struct device *cpu)
diff --git a/src/soc/intel/icelake/cpu.c b/src/soc/intel/icelake/cpu.c
index b1776a09a4..527b989e1a 100644
--- a/src/soc/intel/icelake/cpu.c
+++ b/src/soc/intel/icelake/cpu.c
@@ -192,7 +192,7 @@ void soc_core_init(struct device *cpu)
/* TODO(adurbin): This should only be done on a cold boot. Also, some
* of these banks are core vs package scope. For now every CPU clears
* every bank. */
- mca_configure(NULL);
+ mca_configure();
/* Enable the local CPU apics */
enable_lapic_tpr();
diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c
index 52b0e194e6..a63809bd7e 100644
--- a/src/soc/intel/skylake/cpu.c
+++ b/src/soc/intel/skylake/cpu.c
@@ -428,7 +428,7 @@ void soc_core_init(struct device *cpu)
/* TODO(adurbin): This should only be done on a cold boot. Also, some
* of these banks are core vs package scope. For now every CPU clears
* every bank. */
- mca_configure(NULL);
+ mca_configure();
/* Enable the local CPU apics */
enable_lapic_tpr();