summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVenkata Krishna Nimmagadda <venkata.krishna.nimmagadda@intel.com>2020-05-27 14:26:03 -0700
committerSubrata Banik <subrata.banik@intel.com>2020-05-31 09:37:21 +0000
commitfc3eb1ca1d07b0c864e0f7f6c51c40c5977d4dd3 (patch)
tree84432c82f8ce44bf33a9a60e1299eac1b67d0bb5
parent03a05b47e06392e028dbdb73900219d45084b2fd (diff)
downloadcoreboot-fc3eb1ca1d07b0c864e0f7f6c51c40c5977d4dd3.tar.xz
soc/intel/tigerlake/acpi: Update pch_hda.asl to ASL2.0 syntax
This change updates pch_hda.asl to use ASL2.0 syntax. This increases the readability of the ASL code. BUG=none BRANCH=none TEST="BUILD for Volteer" Signed-off-by: Venkata Krishna Nimmagadda <venkata.krishna.nimmagadda@intel.com> Change-Id: Ia2bab6dcbac9eae76ac4258c44bb19425c8b5c80 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41799 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-by: Subrata Banik <subrata.banik@intel.com>
-rw-r--r--src/soc/intel/tigerlake/acpi/pch_hda.asl14
1 files changed, 6 insertions, 8 deletions
diff --git a/src/soc/intel/tigerlake/acpi/pch_hda.asl b/src/soc/intel/tigerlake/acpi/pch_hda.asl
index f292901b05..08fce8c1f1 100644
--- a/src/soc/intel/tigerlake/acpi/pch_hda.asl
+++ b/src/soc/intel/tigerlake/acpi/pch_hda.asl
@@ -26,19 +26,17 @@ Device (HDAS)
*/
Method (_DSM, 4)
{
- If (LEqual (Arg0, ^UUID)) {
+ If (Arg0 == ^UUID) {
/*
* Function 0: Function Support Query
* Returns a bitmask of functions supported.
*/
- If (LEqual (Arg2, Zero)) {
+ If (Arg2 == 0) {
/*
* NHLT Query only supported for revision 1 and
* if NHLT address and length are set in NVS.
*/
- If (LAnd (LEqual (Arg1, One),
- LAnd (LNotEqual (NHLA, Zero),
- LNotEqual (NHLL, Zero)))) {
+ If ((Arg1 == 1) && (NHLA != 0) && (NHLL != 0)) {
Return (Buffer (One) { 0x03 })
} Else {
Return (Buffer (One) { 0x01 })
@@ -57,9 +55,9 @@ Device (HDAS)
CreateQWordField (NBUF, ^NHLT._MAX, NMAS)
CreateQWordField (NBUF, ^NHLT._LEN, NLEN)
- Store (NHLA, NBAS)
- Store (NHLA, NMAS)
- Store (NHLL, NLEN)
+ NBAS = NHLA
+ NMAS = NHLA
+ NLEN = NHLL
Return (NBUF)
}