summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2016-11-07 16:43:03 -0600
committerMartin Roth <martinroth@google.com>2016-11-11 20:24:06 +0100
commitffae746c373e6e213636daaf704e619926798841 (patch)
tree7ca0d360e8611f880f80ef35948662b877664f8e
parent62d81a0fcc43c43bbf5d9592acb5cd593724a023 (diff)
downloadcoreboot-ffae746c373e6e213636daaf704e619926798841.tar.xz
samsung/stumpy: fix power LED operation
commit 80EF7B7 [IT8772F: Clean up it8772f includes and add a LED API] broke power LED operation when it incorrectly transferred values from the old function (it8772f_gpio_setup) to the new one ( it8772f_gpio_led). Restore the correct values so power LED illuminates when powered on. Change-Id: I99a38351bb52063fafa7436e6397a8da7fc1e952 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/17266 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Martin Roth <martinroth@google.com>
-rw-r--r--src/mainboard/samsung/stumpy/romstage.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/mainboard/samsung/stumpy/romstage.c b/src/mainboard/samsung/stumpy/romstage.c
index 1062b64cae..b2b21c4556 100644
--- a/src/mainboard/samsung/stumpy/romstage.c
+++ b/src/mainboard/samsung/stumpy/romstage.c
@@ -144,8 +144,8 @@ static void setup_sio_gpios(void)
/*
* GPIO45 as LED_POWER#
*/
- it8772f_gpio_led(DUMMY_DEV, 4 /* set */, (0x1 << 5) /* select */,
- 0x00 /* polarity: non-inverting */, 0x00 /* 0 = pulldown */,
+ it8772f_gpio_led(GPIO_DEV, 4 /* set */, (0x1 << 5) /* select */,
+ (0x1 << 5) /* polarity */, (0x1 << 5) /* 1 = pullup */,
(0x1 << 5) /* output */, (0x1 << 5) /* 1 = Simple IO function */,
SIO_GPIO_BLINK_GPIO45, IT8772F_GPIO_BLINK_FREQUENCY_1_HZ);