summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShaunak Saha <shaunak.saha@intel.com>2020-05-12 10:37:59 -0700
committerPatrick Georgi <pgeorgi@google.com>2020-05-18 07:07:54 +0000
commit022d935919e13e5ae0408348328387cd7ece7e66 (patch)
treed0c0c0392571f9281e4330b970523f77861b9359
parent9e9f301b5878d269b7d6b6490279586fe533040a (diff)
downloadcoreboot-022d935919e13e5ae0408348328387cd7ece7e66.tar.xz
mb/ripto: Update ALC5682 headset interrupt configurations
As per schematics configure headset interrupt as edge both for ripto and volteer baseboard. BUG=b:147085988 BRANCH=none TEST=Build and boot ripto board. Test that jack functionality is working fine and also confirm with evtest. Signed-off-by: Shaunak Saha <shaunak.saha@intel.com> Change-Id: I8e1625140ccf55db8cb0fe3c039f1c31c01069b0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41335 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com> Reviewed-by: Duncan Laurie <dlaurie@chromium.org> Reviewed-by: Srinidhi N Kaushik <srinidhi.n.kaushik@intel.com>
-rw-r--r--src/mainboard/google/volteer/variants/baseboard/devicetree.cb2
-rw-r--r--src/mainboard/google/volteer/variants/baseboard/gpio.c2
-rw-r--r--src/mainboard/google/volteer/variants/malefor/gpio.c2
-rw-r--r--src/mainboard/google/volteer/variants/ripto/gpio.c2
4 files changed, 4 insertions, 4 deletions
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
index b68966331c..273b7a8ccc 100644
--- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
@@ -243,7 +243,7 @@ chip soc/intel/tigerlake
register "hid" = ""10EC5682""
register "name" = ""RT58""
register "desc" = ""Realtek RT5682""
- register "irq" = "ACPI_IRQ_EDGE_HIGH(GPP_F8_IRQ)"
+ register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_F8)"
# Set the jd_src to RT5668_JD1 for jack detection
register "property_count" = "1"
register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER"
diff --git a/src/mainboard/google/volteer/variants/baseboard/gpio.c b/src/mainboard/google/volteer/variants/baseboard/gpio.c
index bff7e3c3ad..2ca59aa29d 100644
--- a/src/mainboard/google/volteer/variants/baseboard/gpio.c
+++ b/src/mainboard/google/volteer/variants/baseboard/gpio.c
@@ -260,7 +260,7 @@ static const struct pad_config gpio_table[] = {
/* F7 : GPPF7_STRAP */
PAD_NC(GPP_F7, NONE),
/* F8 : I2S_MCLK2_INOUT ==> HP_INT_L */
- PAD_CFG_GPI_APIC(GPP_F8, UP_20K, DEEP, EDGE_BOTH, INVERT),
+ PAD_CFG_GPI_INT(GPP_F8, NONE, PLTRST, EDGE_BOTH),
/* F9 : Reserved ==> NC */
PAD_NC(GPP_F9, NONE),
/* F10 : GPPF10_STRAP */
diff --git a/src/mainboard/google/volteer/variants/malefor/gpio.c b/src/mainboard/google/volteer/variants/malefor/gpio.c
index f02eb09118..bd66acd57c 100644
--- a/src/mainboard/google/volteer/variants/malefor/gpio.c
+++ b/src/mainboard/google/volteer/variants/malefor/gpio.c
@@ -255,7 +255,7 @@ static const struct pad_config gpio_table[] = {
/* F7 : GPPF7_STRAP */
PAD_NC(GPP_F7, NONE),
/* F8 : I2S_MCLK2_INOUT ==> HP_INT_L */
- PAD_CFG_GPI_APIC(GPP_F8, UP_20K, DEEP, EDGE_BOTH, INVERT),
+ PAD_CFG_GPI_INT(GPP_F8, NONE, PLTRST, EDGE_BOTH),
/* F9 : Reserved ==> NC */
/* F10 : GPPF10_STRAP */
PAD_NC(GPP_F10, DN_20K),
diff --git a/src/mainboard/google/volteer/variants/ripto/gpio.c b/src/mainboard/google/volteer/variants/ripto/gpio.c
index b9041ed263..9a7ca94ebe 100644
--- a/src/mainboard/google/volteer/variants/ripto/gpio.c
+++ b/src/mainboard/google/volteer/variants/ripto/gpio.c
@@ -255,7 +255,7 @@ static const struct pad_config gpio_table[] = {
/* F7 : GPPF7_STRAP */
PAD_NC(GPP_F7, DN_20K),
/* F8 : I2S_MCLK2_INOUT ==> HP_INT_L */
- PAD_CFG_GPI_APIC(GPP_F8, UP_20K, DEEP, EDGE_BOTH, INVERT),
+ PAD_CFG_GPI_INT(GPP_F8, NONE, PLTRST, EDGE_BOTH),
/* F9 : Reserved ==> NC */
/* F10 : GPPF10_STRAP */
PAD_NC(GPP_F10, DN_20K),