diff options
| author | Subrata Banik <subrata.banik@intel.com> | 2019-10-29 17:23:53 +0530 |
|---|---|---|
| committer | Subrata Banik <subrata.banik@intel.com> | 2019-10-31 01:56:41 +0000 |
| commit | 40964fb4ddd09bb38113c66b00fb833ea41b0f93 (patch) | |
| tree | 5d112f790aeb959e7ce19fed6faf5af6b5e49513 | |
| parent | 376357c1078ca53573cfb338877d37398ce76978 (diff) | |
| download | coreboot-40964fb4ddd09bb38113c66b00fb833ea41b0f93.tar.xz | |
soc/intel/icelake: Enable caching on SPI memory-mapped boot device unconditionally
Icelake platform doesn't support booting from any other media
(like eMMC on APL/GLK platform) than only booting from SPI device
and on IA platform SPI is memory mapped hence enabling temporarily
cacheing on memory-mapped spi boot media.
Also removed inclusion of unused header in cpu.c file
TEST=Able to build and boot ICL DE board.
Change-Id: I46d9ec054c4804ca756f2101085a55e91b5cc6f0
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36431
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/soc/intel/icelake/bootblock/cpu.c | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/src/soc/intel/icelake/bootblock/cpu.c b/src/soc/intel/icelake/bootblock/cpu.c index e23286c2d2..da7b7ea153 100644 --- a/src/soc/intel/icelake/bootblock/cpu.c +++ b/src/soc/intel/icelake/bootblock/cpu.c @@ -13,14 +13,19 @@ * GNU General Public License for more details. */ -#include <intelblocks/cpulib.h> #include <intelblocks/fast_spi.h> #include <soc/bootblock.h> void bootblock_cpu_init(void) { - /* Temporarily cache the memory-mapped boot media. */ - if (CONFIG(BOOT_DEVICE_MEMORY_MAPPED) && - CONFIG(BOOT_DEVICE_SPI_FLASH)) - fast_spi_cache_bios_region(); + /* + * Icelake platform doesn't support booting from any other media + * (like eMMC on APL/GLK platform) than only booting from SPI device + * and on IA platform SPI is memory mapped hence enabling temporarily + * cacheing on memory-mapped spi boot media. + * + * This assumption will not hold good for APL/GLK platform where boot + * from eMMC is also possible options. + */ + fast_spi_cache_bios_region(); } |