summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2018-03-04 00:05:12 -0600
committerFurquan Shaikh <furquan@google.com>2018-03-05 18:24:04 +0000
commit41328938081a38b250bbad69829bbe091abf4e6a (patch)
tree924bcb9098793a265a120467c9dd50dfaeea878f
parent908ea9132b2a53470292ac1a346a28a1453f4d7c (diff)
downloadcoreboot-41328938081a38b250bbad69829bbe091abf4e6a.tar.xz
ec/chromeec: Fix check for UHEPI support
Commit 1dfc2c3 [google/chromeec: Enable unified host event programming interface] added support for UHEPI, but google_chromeec_is_uhepi_supported() incorrectly treats negative error return codes from google_chromeec_check_feature() as supported. Fix this check to only treat positive return values as supported, as per the original intent. Test: boot google/lulu, verify cbmem console reports UHEPI not supported even if feature check returns error code, verify lid/kb wake events correctly wakes the device from S3/sleep. Change-Id: I7846efb340bc1546b074e8502daf906c444bd146 Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/24982 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/ec/google/chromeec/ec.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c
index ef7a217c2d..28625e4096 100644
--- a/src/ec/google/chromeec/ec.c
+++ b/src/ec/google/chromeec/ec.c
@@ -224,7 +224,7 @@ bool google_chromeec_is_uhepi_supported(void)
if (!uhepi_support) {
uhepi_support = google_chromeec_check_feature
- (EC_FEATURE_UNIFIED_WAKE_MASKS) ? UHEPI_SUPPORTED :
+ (EC_FEATURE_UNIFIED_WAKE_MASKS) > 0 ? UHEPI_SUPPORTED :
UHEPI_NOT_SUPPORTED;
printk(BIOS_DEBUG, "Chrome EC: UHEPI %s\n",
uhepi_support == UHEPI_SUPPORTED ?