summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJulius Werner <jwerner@chromium.org>2021-03-25 14:44:37 -0700
committerPatrick Georgi <pgeorgi@google.com>2021-04-06 16:04:41 +0000
commit514a4bcb23ef2b87d794aa23c2056b04b018eade (patch)
treee2d507962a4c63661d5f7c7011f937b12fc08cf4
parent89ec3844a567fc4ea94c3618ebed45dea9c5d72b (diff)
downloadcoreboot-514a4bcb23ef2b87d794aa23c2056b04b018eade.tar.xz
lint: checkpatch: Only exclude specific src/vendorcode/ subdirectories
Some of the src/vendorcode/ directories are used to import a whole codebase from somewhere else which uses a completely different coding style. For those directories, excluding them from checkpatch makes sense. However, other directories are simply implementing vendor-specific extensions that were written by coreboot developers specifically for coreboot in coreboot's coding style. Those directories should be covered by checkpatch. This patch narrows the existing blanket exception of src/vendorcode/ to the amd, cavium, intel and mediatek directories (which actually include large amounts of foreign source). The eltan, google and siemens directories (which seem to contain code specifically written for coreboot) will now be covered by checkpatch. Signed-off-by: Julius Werner <jwerner@chromium.org> Change-Id: I1feaba37c469714217fff4d160e595849e0230b9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/51827 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Werner Zeh <werner.zeh@siemens.com> Reviewed-by: David Hendricks <david.hendricks@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--.checkpatch.conf7
-rwxr-xr-xutil/lint/lint-007-checkpatch1
2 files changed, 5 insertions, 3 deletions
diff --git a/.checkpatch.conf b/.checkpatch.conf
index 1bf0a321fb..95019d116e 100644
--- a/.checkpatch.conf
+++ b/.checkpatch.conf
@@ -32,5 +32,8 @@
# some commits unnecessarily.
--ignore EXECUTE_PERMISSIONS
-# Exclude the vendorcode directory
---exclude src/vendorcode
+# Exclude vendorcode directories that don't follow coreboot's coding style.
+--exclude src/vendorcode/amd
+--exclude src/vendorcode/cavium
+--exclude src/vendorcode/intel
+--exclude src/vendorcode/mediatek
diff --git a/util/lint/lint-007-checkpatch b/util/lint/lint-007-checkpatch
index 113d0ae9d1..7a76878f60 100755
--- a/util/lint/lint-007-checkpatch
+++ b/util/lint/lint-007-checkpatch
@@ -15,7 +15,6 @@ EXCLUDED_DIRS="^payloads/libpayload/util/kconfig\|\
^util/inteltool\|\
^util/kconfig\|\
^util/superiotool\|\
-^src/vendorcode\|\
^Documentation"
opts="--max-line-length 96"