summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRichard Spiegel <richard.spiegel@amd.corp-partner.google.com>2018-04-26 08:19:12 -0700
committerPatrick Georgi <pgeorgi@google.com>2018-04-30 06:28:01 +0000
commit7a52c17f16e84e2c7f61eac78c2534927d42dbba (patch)
treed20afb07b4fa835dd5eecbf10558af19d2a8291f
parentccfa18feff26211631be53fe1db1b8b0b534cd79 (diff)
downloadcoreboot-7a52c17f16e84e2c7f61eac78c2534927d42dbba.tar.xz
soc/amd/stoneyridge/gpio.c: Fix gpio_output()
Function gpio_output() is only setting the pin as an output, when in fact it should also set the state (high/low) of the pin. Fix the procedure to set the state of the pin. BUG=b:78328773 TEST=None Change-Id: I516192a0782a9bbb40124029f264a2711114c800 Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com> Reviewed-on: https://review.coreboot.org/25871 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin Roth <martinroth@google.com> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
-rw-r--r--src/soc/amd/stoneyridge/gpio.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/soc/amd/stoneyridge/gpio.c b/src/soc/amd/stoneyridge/gpio.c
index 088f1990d5..4520df7a6f 100644
--- a/src/soc/amd/stoneyridge/gpio.c
+++ b/src/soc/amd/stoneyridge/gpio.c
@@ -95,6 +95,7 @@ void gpio_output(gpio_t gpio_num, int value)
reg = read32((void *)gpio_address);
reg |= GPIO_OUTPUT_ENABLE;
write32((void *)(uintptr_t)gpio_num, reg);
+ gpio_set(gpio_num, value);
}
const char *gpio_acpi_path(gpio_t gpio)