summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt DeVillier <matt.devillier@gmail.com>2017-09-01 14:15:08 -0500
committerMartin Roth <martinroth@google.com>2017-09-16 22:34:11 +0000
commita21d0a1073907b5a87fd31fa195456523d616165 (patch)
tree4d00e69454c0f4dd6b5dbc54331fa321b07802b5
parent6a878a1f24ae77587ade58c35d723362845b2aff (diff)
downloadcoreboot-a21d0a1073907b5a87fd31fa195456523d616165.tar.xz
google/lulu,gandof: set kb backlight on boot
Set keyboard backlight to 75% on boot, except when resuming from S3. This enables the backlight at a reasonable level prior to the OS driver taking over, providing early proof-of-life and enhanced usability in grub etc. Uses same method as other google boards with a keyboard backlight (chell, link, samus). 75% value determined based on user feedback. TEST: boot google/lulu,gandof boards, observe keyboard backlight enabled in pre-OS environment. Change-Id: I7ed59289419af21764b1b5bd0a534d3b630c6c6b Signed-off-by: Matt DeVillier <matt.devillier@gmail.com> Reviewed-on: https://review.coreboot.org/21330 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Martin Roth <martinroth@google.com>
-rw-r--r--src/mainboard/google/auron/variants/gandof/variant.c5
-rw-r--r--src/mainboard/google/auron/variants/lulu/variant.c5
2 files changed, 8 insertions, 2 deletions
diff --git a/src/mainboard/google/auron/variants/gandof/variant.c b/src/mainboard/google/auron/variants/gandof/variant.c
index f1af14d53c..ad88f0d729 100644
--- a/src/mainboard/google/auron/variants/gandof/variant.c
+++ b/src/mainboard/google/auron/variants/gandof/variant.c
@@ -11,6 +11,8 @@
* GNU General Public License for more details.
*/
+#include <ec/google/chromeec/ec.h>
+#include <soc/pm.h>
#include <smbios.h>
#include <soc/romstage.h>
#include <variant/onboard.h>
@@ -35,5 +37,6 @@ int variant_smbios_data(device_t dev, int *handle,
void variant_romstage_entry(struct romstage_params *rp)
{
- /* N/A for boards other than SAMUS */
+ if (rp->power_state->prev_sleep_state != ACPI_S3)
+ google_chromeec_kbbacklight(75);
}
diff --git a/src/mainboard/google/auron/variants/lulu/variant.c b/src/mainboard/google/auron/variants/lulu/variant.c
index 740decfd58..9d77c27c8f 100644
--- a/src/mainboard/google/auron/variants/lulu/variant.c
+++ b/src/mainboard/google/auron/variants/lulu/variant.c
@@ -11,6 +11,8 @@
* GNU General Public License for more details.
*/
+#include <ec/google/chromeec/ec.h>
+#include <soc/pm.h>
#include <smbios.h>
#include <soc/romstage.h>
#include <variant/onboard.h>
@@ -44,5 +46,6 @@ int variant_smbios_data(device_t dev, int *handle,
void variant_romstage_entry(struct romstage_params *rp)
{
- /* N/A for boards other than SAMUS */
+ if (rp->power_state->prev_sleep_state != ACPI_S3)
+ google_chromeec_kbbacklight(75);
}