diff options
| author | Raul E Rangel <rrangel@chromium.org> | 2021-03-16 13:20:23 -0600 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2021-03-31 21:12:36 +0000 |
| commit | a7659ebe4e1101a7a2cbe1f156943e83e9f59249 (patch) | |
| tree | 648c3ca97df73892204cebbc9c269a983110f903 | |
| parent | 3920bc9626a4800d8ad9e63f2e92e5e1ba89bc2a (diff) | |
| download | coreboot-a7659ebe4e1101a7a2cbe1f156943e83e9f59249.tar.xz | |
soc/amd/common/block/graphics: Don't add VBIOS to cbmem when using GOP
pci_rom_ssdt reloads the oprom from cbfs. It then places it into cbmem
and writes the offsets as the ROM ACPI node. The GOP driver modifies the
VBIOS so we don't want to reread from cbfs. When using GOP we also pass
the offsets with the VFCT table.
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Change-Id: Iaf53e750564f1f0e115cd354790da62e672d74b7
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51541
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nikolai Vyssotski <nikolai.vyssotski@amd.corp-partner.google.com>
Reviewed-by: Martin Roth <martinroth@google.com>
| -rw-r--r-- | src/soc/amd/common/block/graphics/graphics.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/soc/amd/common/block/graphics/graphics.c b/src/soc/amd/common/block/graphics/graphics.c index 82b437b155..071dfcc7c5 100644 --- a/src/soc/amd/common/block/graphics/graphics.c +++ b/src/soc/amd/common/block/graphics/graphics.c @@ -108,7 +108,11 @@ static void generate_atif(const struct device *dev) static void graphics_fill_ssdt(const struct device *dev) { acpi_device_write_pci_dev(dev); - pci_rom_ssdt(dev); + + /* Use the VFCT copy when using GOP */ + if (!CONFIG(RUN_FSP_GOP)) + pci_rom_ssdt(dev); + if (CONFIG(SOC_AMD_COMMON_BLOCK_GRAPHICS_ATIF)) generate_atif(dev); } |