summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelix Held <felix-coreboot@felixheld.de>2020-09-15 16:21:46 +0200
committerFelix Held <felix-coreboot@felixheld.de>2020-09-16 14:47:15 +0000
commita79e01bf7167ae6bfc8435341bab87e590789ae9 (patch)
treeda56cdceb34f5b21c74dd0d7519793d54a788d9f
parentbf90b14d6a163a87ad5d0e702b4838754d57b9a6 (diff)
downloadcoreboot-a79e01bf7167ae6bfc8435341bab87e590789ae9.tar.xz
soc/amd/picasso/data_fabric: make register number parameter unsigned
The register number is always non-negative, so it should be an unsigned type. Change-Id: I6b6df5a41fe58efc53eaa87c01b88426ea8daa6e Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/45430 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Raul Rangel <rrangel@chromium.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
-rw-r--r--src/soc/amd/picasso/data_fabric.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/soc/amd/picasso/data_fabric.c b/src/soc/amd/picasso/data_fabric.c
index daeca99909..ac4e23d318 100644
--- a/src/soc/amd/picasso/data_fabric.c
+++ b/src/soc/amd/picasso/data_fabric.c
@@ -12,7 +12,7 @@
#include <soc/pci_devs.h>
#include <types.h>
-static void disable_mmio_reg(int reg)
+static void disable_mmio_reg(unsigned int reg)
{
pci_write_config32(SOC_DF_F0_DEV, NB_MMIO_CONTROL(reg),
IOMS0_FABRIC_ID << MMIO_DST_FABRIC_ID_SHIFT);
@@ -20,7 +20,7 @@ static void disable_mmio_reg(int reg)
pci_write_config32(SOC_DF_F0_DEV, NB_MMIO_LIMIT(reg), 0);
}
-static bool is_mmio_reg_disabled(int reg)
+static bool is_mmio_reg_disabled(unsigned int reg)
{
uint32_t val = pci_read_config32(SOC_DF_F0_DEV, NB_MMIO_CONTROL(reg));
return !(val & ((MMIO_WE | MMIO_RE)));