diff options
| author | Angel Pons <th3fanbus@gmail.com> | 2020-03-07 19:55:17 +0100 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2020-03-09 08:09:11 +0000 |
| commit | c97bf6fdb4882f3cee9e6b72dbee1899036f7ecc (patch) | |
| tree | 43195bcb45167c600586ff047d072985e7c1fd85 | |
| parent | 9900cf80091ad1796c78c04b6ef6302410444480 (diff) | |
| download | coreboot-c97bf6fdb4882f3cee9e6b72dbee1899036f7ecc.tar.xz | |
util/superiotool: Drop one SCH5317 entry
The SCH5317 can have either 0x85 or 0x8c as device ID. However, the
former results in false positives on any ITE IT85xx series embedded
controller, which has led some people to think that chip was actually in
their laptops. Moreover, there is no register dump for the SCH5317.
Since nobody has touched this in over a decade, avoid further confusion
by dropping the misleading definition.
Change-Id: I4d1d34d1b88b878461499e52f1a916ee1e33210d
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39376
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Nico Huber <nico.h@gmx.de>
| -rw-r--r-- | util/superiotool/smsc.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/util/superiotool/smsc.c b/util/superiotool/smsc.c index ab61ba4d19..7e50548ef9 100644 --- a/util/superiotool/smsc.c +++ b/util/superiotool/smsc.c @@ -860,9 +860,6 @@ static const struct superio_registers reg_table[] = { {EOT}}}, {0x83, "SCH5514D", { /* From sensors-detect */ {EOT}}}, - {0x85, "SCH5317", { /* From sensors-detect */ - /* The SCH5317 can have either 0x85 or 0x8c as device ID. */ - {EOT}}}, {0x86, "SCH5127", { /* From sensors-detect, dump from datasheet */ {NOLDN, NULL, {0x02,0x03,0x21,0x22,0x23,0x24,0x26,0x27, |