summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFurquan Shaikh <furquan@google.com>2016-08-17 16:16:39 -0700
committerMartin Roth <martinroth@google.com>2016-08-19 03:03:54 +0200
commitcb6096d71d40c0d15a0abe18ffad1f47c3e7ebf5 (patch)
tree315756ba9503374dc06dda24983a0f1096e9fe11
parent82bd0c352ce75bdc699dbd0940b04e83986dcde5 (diff)
downloadcoreboot-cb6096d71d40c0d15a0abe18ffad1f47c3e7ebf5.tar.xz
intel/apollolake: Skip ITSS configuration in SMM
In SMM, gpio configuration could be done to avoid leakage. ITSS configuration is not required when entering sleep. Thus, bail out early from itss configuration if in SMM. BUG=chrome-os-partner:56281 Change-Id: I4d8be0513aa202f001f980bb91986b50b8ed2a5b Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/16242 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
-rw-r--r--src/soc/intel/apollolake/gpio.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/soc/intel/apollolake/gpio.c b/src/soc/intel/apollolake/gpio.c
index 8b89dfd9a0..8e4ff3ebf4 100644
--- a/src/soc/intel/apollolake/gpio.c
+++ b/src/soc/intel/apollolake/gpio.c
@@ -72,6 +72,10 @@ static const struct pad_community *gpio_get_community(uint16_t pad)
static void gpio_configure_itss(const struct pad_config *cfg,
uint16_t port, uint16_t pad_cfg_offset)
{
+ /* No ITSS configuration in SMM. */
+ if (ENV_SMM)
+ return;
+
int irq;
/* Set up ITSS polarity if pad is routed to APIC.